jolan
-
Posts
54 -
Joined
-
Last visited
Never -
Donations
0.00 GBP
Content Type
Profiles
Bug Tracker
Wiki
Release Notes
Forums
Downloads
Blogs
Events
Posts posted by jolan
-
-
I dont understand, you pushed commit 8d0dcecc1ff50b5d8b16cda0ef82d893bc81a060 "Added loading a custom script dll simple routine" and it is in your branch "madjack", it's in your tree, what's missing ?
did you expect your push to be in your "master" branch ?
-
I agree for shorter hash , "Revision 9d1ac13" is enough, it would also be more readable if used in commit description, patch submission, bug report etc. github and git command accept short hashs.
-
i'm wondering what this code is for :
if(!args) return false;
args is not used ....
[patch] Some Game Event Extensions
in ... under reviewOld
Posted
I just set up a git repo for serverwide event.
first update your local repo :
then pull serverwide event :
then apply sql patches in sql/updates/serverwide_event/
see sql/updates/serverwide_event/readme.txt for DB structure, there is no content sql included so you start with no serverwide event at all but you can test the demo sql from the first post.
the branch dosn't appear on mangos's network graph, that's strange, does someone know why ? [edit] never-mind, github had to refresh it
note : in struct GameEventData (GameEvent.h L54) new variables are not initialized, this is potentially a problem that need analysis