kero99

Link ready again =)

Hi, i have some compile error, my environment is Ubuntu 10.10 server 64bit GCC 4.4.1 - Mangos REV 11382:

In file included from /root/mangosdev/src/game/WardenMgr.h:27,
                from /root/mangosdev/src/game/WardenMgr.cpp:19:
/root/mangosdev/src/game/WorldSession.h:182: warning: unused parameter 'packet'
/root/mangosdev/src/game/WardenMgr.h: In constructor 'WardenMgr::WardenMgr()':
/root/mangosdev/src/game/WardenMgr.h:211: warning: 'WardenMgr::m_Banning' will be initialized after
/root/mangosdev/src/game/WardenMgr.h:207: warning:   'bool WardenMgr::m_HalfCall'
/root/mangosdev/src/game/WardenMgr.cpp:36: warning:   when initialized here
/root/mangosdev/src/game/WardenMgr.cpp: In member function 'void WardenMgr::Initialize(const char*, u_short, bool)':
/root/mangosdev/src/game/WardenMgr.cpp:60: warning: suggest parentheses around assignment used as truth value
/root/mangosdev/src/game/WardenMgr.cpp: In member function 'void WardenMgr::Update(uint32)':
/root/mangosdev/src/game/WardenMgr.cpp:123: warning: unused variable 'res'
/root/mangosdev/src/game/WardenMgr.cpp: In member function 'bool WardenMgr::LoadFromDB()':
/root/mangosdev/src/game/WardenMgr.cpp:186: error: 'WorldDatabase' was not declared in this scope
compilation terminated due to -Wfatal-errors.
make[2]: *** [src/game/CMakeFiles/game.dir/WardenMgr.cpp.o] Error 1
make[1]: *** [src/game/CMakeFiles/game.dir/all] Error 2
make: *** [all] Error 2

Solved adding:

#include "Database/DatabaseEnv.h"

But i have other compile error... maybe related with PCH:

In file included from /root/mangosdev/src/shared/Database/DatabaseEnv.h:40,
                from /root/mangosdev/src/game/WardenMgr.cpp:23:
/root/mangosdev/src/shared/Database/Database.h: In constructor 'Database::Database()':
/root/mangosdev/src/shared/Database/Database.h:308: warning: 'Database::m_pingIntervallms' will be initialized after
/root/mangosdev/src/shared/Database/Database.h:277: warning:   'int Database::m_nQueryConnPoolSize'
/root/mangosdev/src/shared/Database/Database.h:225: warning:   when initialized here
/root/mangosdev/src/game/WardenMgr.h: In constructor 'WardenMgr::WardenMgr()':
/root/mangosdev/src/game/WardenMgr.h:211: warning: 'WardenMgr::m_Banning' will be initialized after
/root/mangosdev/src/game/WardenMgr.h:207: warning:   'bool WardenMgr::m_HalfCall'
/root/mangosdev/src/game/WardenMgr.cpp:37: warning:   when initialized here
/root/mangosdev/src/game/WardenMgr.cpp: In member function 'void WardenMgr::Initialize(const char*, u_short, bool)':
/root/mangosdev/src/game/WardenMgr.cpp:61: warning: suggest parentheses around assignment used as truth value
/root/mangosdev/src/game/WardenMgr.cpp: In member function 'void WardenMgr::Update(uint32)':
/root/mangosdev/src/game/WardenMgr.cpp:124: warning: unused variable 'res'
/root/mangosdev/src/game/WardenMgr.cpp: In member function 'void WardenMgr::SendLoadModuleRequest(WorldSession*)':
/root/mangosdev/src/game/WardenMgr.cpp:520: error: invalid use of incomplete type 'struct WorldSocket'
compilation terminated due to -Wfatal-errors.
make[2]: *** [src/game/CMakeFiles/game.dir/WardenMgr.cpp.o] Error 1
make[1]: *** [src/game/CMakeFiles/game.dir/all] Error 2
make: *** [all] Error 2

Best Regards

Updated versions of patches needed for a MT environment (for rev 1297+)

MTMaps: http://pastebin.com/shkUMvnZ

TBB Concurrent Vector and some safe checks: http://pastebin.com/XSFzAaGB

Spell Update lock (Very hack... but needed): http://pastebin.com/VNdLvLks

Best regards

Update Percona mysql installation to Ubuntu 10.10 Maverick

Hi again, code need some changes to compile in linux, i wrote a little fix, tell me if correct:

http://pastebin.com/f1vi7zJ5

Regards

Hi again Ambal, compile in linux still fail sorry =(, i post it in that commit:

https://github.com/Ambal/mangos/commit/f2d3783421c8cf12d1eb2a4640428949f61c3b97

Best regards

Hi Ambal, thank you soo much for this implementation .

Compile error in linux, i post it in that commit:

https://github.com/Ambal/mangos/commit/fac5959508427baa2da69093220c7a177e546633

Best regards

Update ACE compilation to 5.8.3 (include in latest mangos but you can use a external)

Update cmake compile flags examples to better performance

Maybe you need post it in a bug report section... Not here =)

Testing...

Easy mode patch for merged version: http://pastebin.com/YdCdvmry

Ups sorry, new easy patch for old ver 2: http://pastebin.com/icingfVt

=)

Best regards

Easy mode patch for testing Branch1: http://pastebin.com/fD8iBsxh

Undergarun feedback soon..

Core Version : 11064 but is old bug since 9500+

Patch: RSA fork now but clean when appear in 9500+

Problem:

For some reason when pet id in characters_pet become over some number of 170XXXXX (actually our last pet have id 17043690), all new pet tamed or learned by warlock become "Unknow Entity" (in my case "Entidad Desconocida"):

[sCREENSHOT REMOVED - DO NOT POST SCREENSHOTS OF COPYRIGHTED CONTENT]

In the other realms with max pet id 15622086 or less, the problem dont appear.

A year ago this problem appeared at same number of id and we solved it with a wipe of pets, because i thought in a corrupted data in my db...

Is strange because pet_id value in DB is int 11 and Objectguid maybe is enougth for these values...

Any ideas?

Hmmmm rare, i dont have this issue O_o, mysql config problem?

But RAM usage went down from 28GB to 9GB; so not really sure what those images should tell us.

Is only that to test undergarun restart mysql service and innodb flush all cache in memory... in some days RAM go up to 28 again ... innodb cached memory can be set in my.cnf.

Maybe undergarun show us CPU per thread usage with new db layer, in old layer you can see a big usage of one character mysql connections ( CPU1=68% ) and now you can see two of then (CPU1=31%, CPU3=19%)

Best regards

Hi all, i found in some freeze crashdump (for example http://pastebin.com/Cb38Lmg6) that in thread 7 of crash dump a strange case with spell 13585 (http://www.wowhead.com/spell=13585) in RemoveAuraHolderFromStack:

#0  0x000000000088234d in Unit::RemoveAuraHolderFromStack (
   this=0x7fff035e8100, spellId=0, stackAmount=0, 
   casterGUID=17379391082114100824, mode=AURA_REMOVE_BY_DISPEL)
   at ../../../src/game/Unit.cpp:4905
No locales.
#1  0x0000000000889d9e in Unit::RemoveAuraHolderDueToSpellByDispel (
   this=0x7fff035e8100, spellId=13585, stackAmount=2, 
   casterGUID=17379391082114100824, dispeler=0x26b30000)
   at ../../../src/game/Unit.cpp:4822
       spellEntry = 0x7fffe676aa00

Could be related this with some freezes? or is only a casuality?

Best regards

OMG!!!!!!!!!!!! Is a wondeful patch!!!!!! Really i need it!!!!! =)

But i have some pain to test it in production environment with 2000+ ppl online... i need to prepare some event in a RPP server

Thanks soo much

lol, not soo much voluntaries . Ok ok, i have some free time again =), i would test and post feedback

Best regards

Derex Finally solved the problem: 48h without ACE crashes :

0ab04bd1b0624640ec3e108bd12508829be51ad6
src/game/WorldSocket.cpp |    1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/game/WorldSocket.cpp b/src/game/WorldSocket.cpp
index 8b59038..667b039 100644
--- a/src/game/WorldSocket.cpp
+++ b/src/game/WorldSocket.cpp
@@ -445,6 +445,7 @@ int WorldSocket::handle_close (ACE_HANDLE h, ACE_Reactor_Mask)
        m_Session = NULL;
    }

+    reactor()->remove_handler(this, ACE_Event_Handler::DONT_CALL | ACE_Event_Handler::ALL_EVENTS_MASK);
    return 0;
}

Original code from: https://github.com/TrinityCore/TrinityCore/commit/45459bed23b78fc619475ee2177e826ae4494cd7

Best regards

Sorry for reply later, very busy week =(... i try yesterday to put in the production server put old_way branch not compile in linux: http://pastebin.com/3fbQM02v =(

(Compiling in clean silverice repo)

Best regards

As I see, everyone are so scared after commits [10688] and [10677] so noone is willing to test similar patches anymore Ok, let's go another way: if you want more patches from me, test this one

I can test patch but need first some days to finish with Reloc branch1 test ... Soo much amazing patches to test in few days!!!! hehehe

Your crash is not related with Ambal patch, this crash is from mtmaps patch and concurrent access to DB Functions (damned windows dumps..).

At the moment you still need TBB Concurrent Vector patch (prevent crashes by corruption pointer in targets) and SQLAsynq patch (Prevent crashes in SQL Functions concurrent access) in MTMaps thread to work more or less stable in MapUpdate.Threads = 2 or more.

And then you will see than MTMaps still dont enought stable ... but we needed ^^

Best regards

Ok, i will apply branch 1 at weekend and test some days =)

Best regards

Hi all, here my feedback in about 1 week testing with default patch config:

Visibility.RelocationLoverLimit = 10

Visibility.AIRelocationNotifyDelay = 1000

And:

Visibility.GroupMode = 0

Visibility.Distance.Continents = 90

Visibility.Distance.Instances = 120

Visibility.Distance.BGArenas = 180

Visibility.Distance.Object = 100

Visibility.Distance.InFlight = 100

Visibility.Distance.Grey.Unit = 1

Visibility.Distance.Grey.Object = 10

MTMaps Actived? Not active for good CPU testing

Clean Core? No, some patches

Playerlimit to testing: 2000

Core Server (DB in other server): Intel Bi Xeon X5650 2 x 6 x 2 x 2.66+GHz - 24GB DDR3 ECC RAM - Ubuntu Server 9.10

Result:

HTOP CPU Usage with 2000 Players WITHOUT Visibility and Reloc simplified: 95 - 100% -> ~98%

HTOP CPU Usage with 2000 Players WITH Visibility and Reloc simplified: 75 - 98% -> ~87%

Max gain of CPU ~20%

Standard gain: ~11%

Minimal gain: ~2%

Some problem in gameplay detected by testers? No

Some problem in stability? No

Conclusion: The patch is really good and help soo much in CPU Usage

Best regards

For ACE or OpenMP MTMaps