KiriX

1. Can you give me any more details? :rolleyes:

i.e Describe your system, which version of ScriptDev2 are you using, any other mods used.

2. Did it crash during compilation or runtime?

3. What were you doing when it crashed? i.e were you trying to use 'Pappy Looter' for instance

4. How did you apply playerbot to MaNGOS [9044], the code was adjusted for MaNGOS [9043].

i.e Did you try merging or did you create a 'patch' and apply this to a fresh MaNGOS [9044]?

Please get back to me, blueboy

1. Win server 2003; SD2 rev.1523; many patch, but crash (as say CrashLog) in playerbot (sorry, crashlog was deleted, but I remember line with isBotGiver())

2. During runtime

3. When player try to speak with any NPC

4. git pull git://github.com/blueboy/mangos.git without any conflict

I try in game now after http://github.com/blueboy/mangos/commit/86e640ebfcb6dc982883e34bb12f289370571ad6

added

Crash:

Call stack:
Address   Frame     Function      SourceFile
0065E747  00000000  ?GetScriptId@Creature@@QBEIXZ+37
0065E6D8  00000000  ?GetScriptName@Creature@@QBE?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@XZ+18
00731DB7  00000000  ?[b]isBotGiver[/b]@Creature@@QAE_NXZ+37
004F975E  00000000  ?PrepareGossipMenu@Player@@QAEXPAVWorldObject@@I@Z+DE
00668725  00000000  ?Use@GameObject@@QAEXPAVUnit@@@Z+115
008AAE4A  00000000  ?HandleGameObjectUseOpcode@WorldSession@@QAEXAAVWorldPacket@@@Z+16A
005E9DB0  00000000  ?Update@WorldSession@@QAE_NI@Z+120
005FBB83  00000000  ??0CreatureEventAI@@QAE@ABV0@@Z+8243
005FA301  00000000  ??0CreatureEventAI@@QAE@ABV0@@Z+69C1
00430BCE  00000000  ?getSource@?$Reference@V?$GridRefManager@VCorpse@@@@VCorpse@@@@QBEPAVCorpse@@XZ+1931E
008C9859  00000000  ?GetFloatDefault@Config@@QAEMPBDM@Z+DC9
00AF14D4  00000000  ?invoke@ACE_OS_Thread_Adapter@@UAEKXZ+74
78543433  00000000  _endthreadex+44
785434C7  00000000  _endthreadex+D8
7C82482F  00000000  GetModuleHandleA+DF

Go to try Stillhard fix...

added

Stillhard, thx! I have no crash with your fix

rev. 9044 with http://github.com/blueboy/mangos/commit/ce4c26a5545e2d47aa53a59e510f2921b114de74

Crash again

I had to roll back these changes

This will no longer work in current revisions. It causes a crash due to the recent modifications in shapeshifting.

I don't think that this patch can be reason for the crash...

I have no idea how this patch can cause crash after last modifications in shapeshifting...

blueboy, thx for work!

Work well with 9014 after last change

MaNGOS rev.9014

$ git pull git://github.com/blueboy/mangos.git master
remote: Counting objects: 1489, done.
remote: Compressing objects: 100% (280/280), done.
emote: Total 1367 (delta 1132), reused 1316 (delta 1087)Receiving objects: 100%
Receiving objects: 100% (1367/1367), 530.90 KiB | 111 KiB/s, done.

Resolving deltas: 100% (1132/1132), completed with 38 local objects.
From git://github.com/blueboy/mangos
* branch            master     -> FETCH_HEAD
Auto-merging src/game/GossipDef.h
Auto-merging src/game/NPCHandler.cpp
CONFLICT (content): Merge conflict in src/game/NPCHandler.cpp
Auto-merging src/game/Player.cpp
Auto-merging src/game/Player.h
Automatic merge failed; fix conflicts and then commit the result.

You will update the patch?

False.Genesis, can you link you full patch as diff file?

Some time ago I try make patch like this (I think this very useful), but could not found correct data from dbc for existing in code summon_types (could not find a common code and dbc values). They was different and patch will be buged, if I use data from dbc.

MaNGOS need in patch for summon_type from dbc, thanks for you work - I'll go to test it ...

I hope that this patch is not buged as my

It's you mistake, becouse this patch work well for me and XTZGZoReX...

What bug does the patch fix? What features does the patch add?

Fix damage from Drain Soul.

If the target is at or below 25% health, Drain Soul causes four times the normal damage.

For which repository revision was the patch created?

8684

Who has been writing this patch?

Me

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index 8015555..f781916 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -4469,6 +4469,16 @@ void Aura::HandlePeriodicDamage(bool apply, bool Real)
                }
                break;
            }
+			case SPELLFAMILY_WARLOCK:
+			{
+				if (m_spellProto->SpellIconID == 113)
+				{
+					if (m_target->GetHealth() <= m_target->GetMaxHealth()*0.25f)
+						m_modifier.m_amount *= 4;
+					return;
+				}
+				break;
+			}
            case SPELLFAMILY_WARRIOR:
            {
                // Rend

Anybody test it? Work well for me...

Yes. Should be so...

Need test

1) Spells hasn't SPELL_AURA_MOD_SPEED_FLIGHT + SPELL_AURA_MOD_SPEED_MOUNTED in same time in their structure. (from spell.dbc)

2) However is you cast spell causing aura SPELL_AURA_MOD_SPEED_FLIGHT does spell causing aura : SPELL_AURA_MOD_SPEED_MOUNTED is always removed ?

And vice versa ?

I think but I'm not sure...

1) Yes, it's may be... But what about 2 spells that can have SPELL_AURA_MOD_SPEED_FLIGHT and SPELL_AURA_MOD_SPEED_MOUNTED??? Why you think that SPELL_AURA_MOD_SPEED_MOUNTED will be always removed?

2) SPELL_AURA_MOD_SPEED_FLIGHT + SPELL_AURA_MOD_SPEED_MOUNTED becouse I don't know is SPELL_AURA_MOD_SPEED_FLIGHT use in some spell now or not use. If remove SPELL_AURA_MOD_SPEED_FLIGHT we can break some spell with this aura type.

What bug does the patch fix? What features does the patch add?

Fix mana restore by Owlkin Frenzy.

For which repository revision was the patch created?

8658

Who has been writing this patch?

Me

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index e0db4c2..c296256 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -4378,6 +4378,9 @@ void Aura::HandlePeriodicEnergize(bool apply, bool Real)
    if (GetId() == 57669 ||
        GetId() == 61782)
        m_modifier.m_amount = m_target->GetMaxPower(POWER_MANA) * 25 / 10000;
+		
+	if (GetId() == 48391)
+		m_modifier.m_amount = m_target->GetCreateMana() * 2 / 100;
}

void Aura::HandleAuraPowerBurn(bool apply, bool /*Real*/)

What bug does the patch fix? What features does the patch add?

Fix increase flight speed in druid flight form.

For which repository revision was the patch created?

8649

Who has been writing this patch?

Me

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp 
index 43f9e5a..e5fb51c 100644 
--- a/src/game/SpellAuras.cpp 
+++ b/src/game/SpellAuras.cpp 
@@ -256,7 +256,7 @@ pAuraHandler AuraHandler[TOTAL_AURAS]= 
    &Aura::HandleNoImmediateEffect,                         //203 SPELL_AURA_MOD_ATTACKER_MELEE_CRIT_DAMAGE  implemented in Unit::CalculateMeleeDamage and Unit::CalculateSpellDamage 
    &Aura::HandleNoImmediateEffect,                         //204 SPELL_AURA_MOD_ATTACKER_RANGED_CRIT_DAMAGE implemented in Unit::CalculateMeleeDamage and Unit::CalculateSpellDamage 
    &Aura::HandleNULL,                                      //205 vulnerable to school dmg? 
-    &Aura::HandleNULL,                                      //206 SPELL_AURA_MOD_SPEED_MOUNTED 
+    &Aura::HandleAuraModIncreaseFlightSpeed,                //206 SPELL_AURA_MOD_SPEED_MOUNTED 
    &Aura::HandleAuraModIncreaseFlightSpeed,                //207 SPELL_AURA_MOD_INCREASE_FLIGHT_SPEED 
    &Aura::HandleAuraModIncreaseFlightSpeed,                //208 SPELL_AURA_MOD_SPEED_FLIGHT, used only in spell: Flight Form (Passive) 
    &Aura::HandleAuraModIncreaseFlightSpeed,                //209 SPELL_AURA_MOD_FLIGHT_SPEED_ALWAYS 
diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp 
index 7e6f7f9..e3ce0a4 100644 
--- a/src/game/Unit.cpp 
+++ b/src/game/Unit.cpp 
@@ -9950,7 +9950,7 @@ void Unit::UpdateSpeed(UnitMoveType mtype, bool forced) 
            if (IsMounted()) // Use on mount auras 
                main_speed_mod  = GetMaxPositiveAuraModifier(SPELL_AURA_MOD_INCREASE_FLIGHT_SPEED); 
            else             // Use not mount (shapeshift for example) auras (should stack) 
-                main_speed_mod  = GetTotalAuraModifier(SPELL_AURA_MOD_SPEED_FLIGHT); 
+                main_speed_mod  = GetTotalAuraModifier(SPELL_AURA_MOD_SPEED_FLIGHT) + GetTotalAuraModifier(SPELL_AURA_MOD_SPEED_MOUNTED); 
            stack_bonus     = GetTotalAuraMultiplier(SPELL_AURA_MOD_FLIGHT_SPEED_ALWAYS); 
            non_stack_bonus = (100.0 + GetMaxPositiveAuraModifier(SPELL_AURA_MOD_FLIGHT_SPEED_NOT_STACK))/100.0f; 
            break;

Can anyone tell me if the patch is ok (after the latest update)? I cannot test it now, tell me if there are problems or not

Can you link full patch as diff file?

/g is work. Tested. I always use it.

If you separate stat fix, it may be get in git soon, I think...

Crash at "attack" target command if bot far away (another map) and fights with other target...

From http://getmangos.ru:

This code

   if( pet )
   {
       if( ((float)pet->GetHealth()/(float)pet->GetMaxHealth()) < 0.5f )
       {
           // heal pet when health lower 50%
           if( PET_MEND>0 && !pet->HasAura(PET_MEND,0) && ai->CastSpell(PET_MEND,*m_bot) )
           {
               ai->TellMaster( "healing pet" );
               return;
           }
       }
   }

replace (It is better to replace it:):

   if(( pet ) 
   && ( ((float)pet->GetHealth()/(float)pet->GetMaxHealth()) < 0.5f )
   && ( PET_MEND>0 && !pet->HasAura(PET_MEND,0) && ai->CastSpell(PET_MEND,*m_bot) ))
   {
       ai->TellMaster( "healing pet" );
       return;
   }

This patch cause the bug with GO (3.0.3 sourse rev.6996).

For example:

Change mouse-icon-on grass as it chest GO, don't open and don't required herbalist skill. Anvil icon look like grass icon...

I hope, you are understand me.

Sorry for my English. I'm from mangos.ru... =)