kolomati

in worst case only a non-existent spell that should be cast as achievement-criteria on encounter-end

As far as i know those encounters that do not kill a boss have a server side spell casted.

For example four horsemen encounter in Naxxramas:

pPlayer->GetAchievementMgr().UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_BE_SPELL_TARGET, 59450, 0);

with proper SQL entries to actually check if it was 10 or 25 man:

INSERT INTO `achievement_criteria_requirement` (`criteria_id`,`type`,`value1`,`value2`) VALUES
('7192', '12', '0', '0'), ('7193', '12', '1', '0');

Regards.

Add this to Player.cpp:

diff --git a/src/game/Player.cpp b/src/game/Player.cpp
index e818df5..5caeb02 100644
--- a/src/game/Player.cpp
+++ b/src/game/Player.cpp
@@ -2399,6 +2399,9 @@ void Player::GiveXP(uint32 xp, Unit* victim)
    if(!isAlive())
        return;

+    if(HasFlag(PLAYER_FLAGS, PLAYER_FLAGS_XP_USER_DISABLED))
+        return;
+
    uint32 level = getLevel();

    // XP to money conversion processed in Player::RewardQuest

Regards.

What bug does the patch fix? What features does the patch add?

It lets the one disable creating Heroic Characters in the configuration file mangosd.conf. According to the conf file tip:

# HeroicCharactersPerRealm

# Limit numbers of heroic class characters for account at realm

# Default: 1

# The number must be between 0 (not allowed) and 10

At the moment it is not possible to set this value to 0, because it gets automatically adjusted back to 1 by the server, so you cannot disable Heroic Characters creation.

For which repository revision was the patch created?

9766

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

Forum search did not show any results.

Who has been writing this patch? Please include either forum user names or email addresses.

[email protected]

diff --git a/src/game/World.cpp b/src/game/World.cpp
index 30b093a..679e502 100644
--- a/src/game/World.cpp
+++ b/src/game/World.cpp
@@ -568,7 +568,7 @@ void World::LoadConfigSettings(bool reload)
    // must be after CONFIG_UINT32_CHARACTERS_PER_REALM
    setConfigMin(CONFIG_UINT32_CHARACTERS_PER_ACCOUNT, "CharactersPerAccount", 50, getConfig(CONFIG_UINT32_CHARACTERS_PER_REALM));

-    setConfigMinMax(CONFIG_UINT32_HEROIC_CHARACTERS_PER_REALM, "HeroicCharactersPerRealm", 1, 1, 10);
+    setConfigMinMax(CONFIG_UINT32_HEROIC_CHARACTERS_PER_REALM, "HeroicCharactersPerRealm", 1, 0, 10);

    setConfig(CONFIG_UINT32_MIN_LEVEL_FOR_HEROIC_CHARACTER_CREATING, "MinLevelForHeroicCharacterCreating", 55);

What bug does the patch fix? What features does the patch add?

The patch allows using mounts in dungeon map 595 (CoT: Culling of Stratholme).

For which repository revision was the patch created?

9246

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

Didn't find any.

Who has been writing this patch? Please include either forum user names or email addresses.

me

Patch:

http://paste2.org/p/629530

Regards.

MaNGOS: 8558

ScriptDev2: 1422

UDB: 382 + http://udbforums.org/index.php?topic=14328

Do BGs start and end correctly?

Tested WSG, started and ended correctly. 10 testers on both sides.

Do BG creatures/gameobjects spawn/despawn correctly?

Everything has spawned and despawned correctly. Flags were properly placed, doors were fine.

Do BG flag pickup/drop events work correctly?

Events work perfectly well.

Do BGs crash (if so, include backtrace!)?

Haven't crashed for me on a "loaded" server.

Regards.

Great job !