Naicisum

Ok, been a while so lets start with the comments... @X-Savior I do have removing the player from the database on the list of things to do, ive been working on customization feature first to allow a fine granularity to what you can do with the ahbot. But due to my first few attempts at this realized this would take a while for me, I need to learn how to recode the affected sections around items to not need a player, some look straight forward others do not. I do want to remove this all togeather and would love to see this merged into master! @reno138 If you would like, I can add your info to the 1st post for the v0.12 ahbot that your running... Let me know. @Gimp, UncleNuke I wouldn't mind looking over that code and bringing it in (with authors consent/permissions and correct credits), but I want to finish my changes to the next revision first before losing focus or getting distracted. @ckegg Concerning the buyer stopping, strange, I will try to replicate this on my end. @All/Everyone So where I stand, well ive finished most of the DB changes for the config db table. Im focusing on the override table at the moment and once thats finished, ill post upload the code to the dev branch for a so called "BETA" before merging it back into the main ahbot. I will post when this is done and ask for volenteers for testing this new branch. I was sick last week which ment I slept and was slow to update the repo (i try to keep this a morning task), and Ive thought of automatically doing this but it does help to quickly peruse the recent changes to see if any will pop out to me and cause a problem. As to the DB corruption, im not sure how that can happen (but im sure there always is a way), the recent problem on my end that I corrected in HotFix-06 concerned an incorrect flag that didnt tell mangos to remove the items from the item_instance table in the characters database. I apologize again to everyone for this oversite. Keep in mind i try to keep all the code using standard mangos functions and try to modify the main code as little as possible, this is what helps keep the code working when they change things to how those functions work. I will also look into what happens if there are no/few items for auction with large values set, and experiment more with two sided interaction config. Right now I dont test with two sided set, but will add this to the list of things for regression testing. I also updated my repo as of this morning, created a "ahbot-mangos-v0.15" tag for the last version with v0.15 main, since I know some of you like this feature. Now I have to go generate all new files and recomp my server.

@Gimp The reason why these items are not sold is due to their prices in the mangos database, specifically the BuyPrice and SellPrice columns in the item_template table. In addition, the AHBot option AuctionHouseBot.UseBuyPriceForSeller, is used to determine which column is used during initial loading to determine which price is to be used, if the value of this option is 0 then the SellPrice column is used, if its 1 the BuyPrice column is used. If an item has a value of 0 in the column that is used, the AHBot will skip over this item because any pricing formula used against 0 will be 0 and we dont want free items on the AHBot now. This applies for all item types. On the specifics you requested above, heres how you can examine your DB using this query. SELECT entry, name, buyprice, sellprice FROM <MANGOS DB>.item_template WHERE bagfamily = 64 AND class = 7; Using the query above you can determine what will sell and not sell based on the configuration parameters outlined above. At present you have a couple of options, you can switch the config value for the AHBot, but please recognize how this will change the AH prices, or you can manually update and set a price for those items that have a current value of 0. The next version of the AHBot will have an override table for individual items so you dont have to modify the values of this table, I know this is a heavily requested feature and its coming! I hope this helps address your issue.

@Everyone HotFix-06 has been posted that fixes the issues with expired ahbot auctions not being removed from item_instance. Below are some SQL statements to identify how many rows need to be removed, and the statement to remove those rows without affecting active auctions. This will remove everything from the AHBot character, including any items it may have on or in its inventory. This is a non issue, it shouldn't be used for this anyhow. BACKUP YOUR DATABASE BEFORE DOING THESE REPAIR STEPS! BACKUP BACKUP BACKUP! The SQL statements MUST be run while the mangos server is off and against your characters database. Displays how many rows should not exist select count(*) from item_instance left outer join auctionhouse on auctionhouse.itemguid = item_instance.guid where auctionhouse.itemguid is null and item_instance.owner_guid = <AHBOT GUID>; Removes extra rows delete ii from item_instance as ii left outer join auctionhouse as ah on ah.itemguid = ii.guid where ah.itemguid is null and ii.owner_guid = <AHBOT GUID>; delete from character_inventory where guid = <AHBOT GUID>;

@Everyone Looks like I accidentally introduced a bug when the Mail system underwent its revision, its not removing the rows from the item_instance table when auctions expire. I am testing a hotfix that corrects this issue as we speak, i dont really look at the table row counts all that much, but having 4.2M rows is a bit much for that table for my server. I need to let the server run with this new code for a couple of hours to make sure that the rows are getting removed as they normally should be.

@kaxias Yes, I'm still alive and kicking... Still trying to tweak away at the DB code, mostly my grief is with reworking the SQL functions to use a row based system instead of a column based system... @All Trying to keep the main branch updated as well, sorry for that brief kick a couple of days ago, a simple white-space correction killed the merge which i corrected...

@All/Everyone Just some news to know where development is at, I was originally going to use a data blob to store the config, but it really is inefficient. I was inspired by Hunuza [8874] to instead use the newer method they are converting the blob to, it is much more efficient to use, requires less calculation, and makes for easier expansion. So I have to rewrite a chunk of the DB code which I almost had implemented the blob way for this newer method. The newer method will make things much simpler and help assist with the per item overrides since i would have had to write a similar db method anyhow. Coding has been coming slow, mostly due to RL issues, but I havent forgotten about you guys and I'm still very much interested in completing this project. Once again, thank you all for your continued support and patience with me on this endevor. PS. On a side note, is everything working ok or are there still some outstanding issues? Ive seen a couple of the above issues, but I wanted to know if they are old or current.

@All/Everyone Sorry for the late repo updates, been a crazy last two weeks for me. I just pushed a repo update as of this morning. Also AHBot-004-HotFix-05 was posted a while back, my bad on forgetting to post a new note on the tail end of the thread here, i updated the main post but forgot this part. This merge fix was to address all the singleton macro renames.

@Shyke If you examine my first post, i detail how to extract and create a patch file. From there you can ad-hoc it to your changes.

@Everyone [AHBot-004-HotFix-04] is now live which address the Mail change. Stability seems to be ok with no issues I have noticed thus far.

@Everyone Sorry for the Delay. I have a patch finished for the changes and im in the process of testing the patch for functionality and stability. It should be a minor fix but I wanted to run through the new mail code and make sure I understood it and didnt miss anything. If all goes well, ill push to my repo to github and were golden again. Ill post another update when ive pushed the changes and update my first post.

Mangos Rev 8768 has broken the AHBot, the recent changes in the mail system in this update need to be modified in the code. I will be working on looking at these changes tonight and hopefully have an update to the branch within a couple of days time permitting.

@X-Savior Hopefully the GIT is strong with me this time. I beleive I corrected the tag, I had to revert, remerge, retag, and force a git update of the ahbot branch, but it should be good now. @Skirnir and Everyone I know I know, ive been in lazy mode since getting back from my Vacation, but I'm planning on putting in some serious dev hours this weekend on getting another push up on the dev branch. Hopefully I'll make some progress and have an update on where things stand on development by Monday. Thank you all for your support and patience!

I have merged the master branch but it looks like there might be some more core issues at the moment. I will post when I have a sucessful merge/running server with AHBot running. Thanks for your patience.

@neonblue Not sure, I just updated the repo to rev 8526 and recompiled my server @ 8526 with no issues. Its up and running right now again, i logged in poked my head around and spot checked a few areas and it seems to be stable... @cytrik Is this still an issue, if so could you re-elaborate on whats going on if anything has changed since your posting? Thanks!

@killsakiller The formula is good, however it must always be less than the max value for it to sell, which is why i suggested subtracting 1 from max value which is the same as 1 copper. @Namesis Not sure, but if your mangos output dosent show the "Initialize AuctionHouseBot..." etc etc, then your source isint patched/compiled correctly. Im not sure how to patch outside of using git, ive used msysgit which is basically git for windows... Ref: http://code.google.com/p/msysgit/ @Everyone I will be going on vacation starting this saturday for three full weeks returning back to the grind on the 14th of September, I will try to keep the repo updated but there may be gaps in the days when this occurs. I ask for your patience and will try to keep the repo updated when I get a chance. Thanks!