Serker

Mana Tap needs to be removed from code too. Current code still checks for Mana Tap's. Something like

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index bc1316f..2c5b14a 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -3730,26 +3730,6 @@ void Aura::HandleAuraModSilence(bool apply, bool Real)
                }
            }
        }
-
-        switch (GetId())
-        {
-            // Arcane Torrent (Energy)
-            case 25046:
-            {
-                Unit * caster = GetCaster();
-                if (!caster)
-                    return;
-
-                // Search Mana Tap auras on caster
-                Aura * dummy = caster->GetDummyAura(28734);
-                if (dummy)
-                {
-                    int32 bp = dummy->GetStackAmount() * 10;
-                    caster->CastCustomSpell(caster, 25048, &bp, NULL, NULL, true);
-                    caster->RemoveAurasDueToSpell(28734);
-                }
-            }
-        }
    }
    else
    {

Rev. 7487 with patch:

Compiling...
Unit.cpp
..\\..\\src\\game\\Unit.cpp(1727) : error C2146: syntax error : missing ')' before identifier 'SpellProto'
..\\..\\src\\game\\Unit.cpp(1727) : error C2065: 'SpellProto' : undeclared identifier
..\\..\\src\\game\\Unit.cpp(1727) : error C2227: left of '->SpellIconID' must point to class/struct/union/generic type
       type is ''unknown-type''
..\\..\\src\\game\\Unit.cpp(1727) : error C2059: syntax error : ')'
..\\..\\src\\game\\Unit.cpp(1728) : error C2143: syntax error : missing ';' before '{'

Without it, compiles normally.

Tested with some revs up to 7460, it works almost properly. The only mistake is, this can be activated ony in cat/bear form, and your patch makes it usable in any form.

Rev.7428+ScriptDev2 901, with anti-cheat, x32:

Revision: * * 7428 *
Date 10:3:2009. Time 17:41 
//=====================================================
*** Hardware ***
Processor: Intel(R) Pentium(R) 4 CPU 3.00GHz
Number Of Processors: 2
Physical Memory: 3136236 KB (Available: 2080768 KB)
Commit Charge Limit: 4194303 KB

*** Operation System ***
Microsoft Windows XP Professional Service Pack 3 (Version 5.1, Build 2600)

//=====================================================
Exception code: C0000005 ACCESS_VIOLATION
Fault address:  0060932C 01:0020832C D:\\MaNGOS_bin\\mangosd.exe

Registers:
EAX:00000000
EBX:013CA9E8
ECX:00000000
EDX:AA009E84
ESI:0012FACC
EDI:0012FAA0
CS:EIP:001B:0060932C
SS:ESP:0023:0FCDFA8C  EBP:0FCDFA94
DS:0023  ES:0023  FS:003B  GS:0000
Flags:00010212

Call stack:
Address   Frame     Function      SourceFile
0060932C  00000000  WorldSession::GetMangosString+C
00816B95  00000000  WorldSession::SendTrainerList+35
0F9701DF  00000000  ?GetSession@Player@@QBEPAVWorldSession@@XZ+171F
0F970ABB  00000000  ?GetSession@Player@@QBEPAVWorldSession@@XZ+1FFB
0FA4DA04  00000000  GossipSelect+64
00818032  00000000  WorldSession::HandleGossipSelectOptionOpcode+342
00607D36  00000000  WorldSession::Update+176
00631CD4  00000000  World::UpdateSessions+154
0062DF35  00000000  World::Update+365
004388BE  00000000  WorldRunnable::run+8E
008DF905  00000000  ZThread::ThreadImpl::Dispatch+1D5
008DFD63  00000000  ZThread::`anonymous namespace'::Launcher::run+33
008E3E17  00000000  ZThread::ThreadOps::_dispatch+17
78543433  00000000  _endthreadex+44
785434C7  00000000  _endthreadex+D8
7C80B713  00000000  GetModuleFileNameA+1B4

Call stack:
Address   Frame     Function      SourceFile
7C90E4F4  00000000  KiFastSystemCallRet+0
7C802542  00000000  WaitForSingleObject+12
10009C64  00000000  __WSAFDIsSet+FFFFFFFFFFF84BEC
100764DA  00000000  __WSAFDIsSet+FFFFFFFFFFFF1462
1007269F  00000000  __WSAFDIsSet+FFFFFFFFFFFED627
006479BA  00000000  WorldSocketMgr::Wait+4A
12B65FC4  00000000  0000:00000000 
12B65FC4  00000000  0000:00000000 
6C696146  00000000  

There are eight(!) crashes today, looks absolutely identically...

update `spell_bonus_data` set `direct_bonus` = 0.6453 where `entry` = 33763;

Lifebloom has a 0 coefficient for final heal, which is incorrect...

Rev 7324(clean), a shaman with mace in offhand and the same problem...