Jump to content

Shadez

Members
  • Posts

    158
  • Joined

  • Last visited

    Never
  • Donations

    0.00 GBP 

Posts posted by Shadez

  1. First: you should not create separate threads to discuss some errors/bugs of wowcs project.

    Second: i have no troubles with patching mangos sources at [11544] mangos rev. and [88] wowcs rev:

    Shadez@SHADEZ-PC /e/MaNGOS/!_Sources/mangos-335/mangos (master)
    $ patch -p1 < wowarmory_patch.patch
    patching file `src/game/AchievementMgr.cpp'
    patching file `src/game/Item.cpp'
    patching file `src/game/Player.cpp'
    Hunk #1 succeeded at 4327 (offset 8 lines).
    Hunk #2 succeeded at 15345 (offset 3 lines).
    Hunk #3 succeeded at 17318 (offset 8 lines).
    Hunk #4 succeeded at 22847 (offset 19 lines).
    patching file `src/game/Player.h'
    Hunk #2 succeeded at 2268 (offset 2 lines).
    patching file `src/game/Unit.cpp'

  2. I found some time to look into it myself and it is working for me now. I will post the code I changed.

    Thank you, I will test it on weekends and commit changes to repository.

    If i give you details could this be implemented to lightweight the 3d model viewer?

    I don't think that it's a good idea because my principle is avoid including 3rd party changes to Armory - only Retail Armory features could be implemented in this project.

    But if you can implement it, I can commit it as separate custom patch and who wants to use it, will patch original sources with your changes.

  3. I will try to do this myself when I get to the point of updating to that core and post the changes here if you didn't do it yourself yet
    It will be very helpful because at this moment I don't have free time even to update core patches to new revisions. But project is not dead, don't even think about it :) At least at now :)

    I guess I'll close this one after I'll finish my work under new WoW Commnunity Site but I can't say how much time it will take.

  4. * What bug does the patch fix? What features does the patch add?

    Properly reward faction related titles to player when achievement has been completed (currently just one - 100k honor kills - %s of the Alliance / %s of the Horde).

    * For which repository revision was the patch created?

    11139

    * Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

    No

    * Who has been writing this patch? Please include either forum user names or email addresses.

    Me

    diff --git a/src/game/AchievementMgr.cpp b/src/game/AchievementMgr.cpp
    index 2a0269d..7b4cdfa 100644
    --- a/src/game/AchievementMgr.cpp
    +++ b/src/game/AchievementMgr.cpp
    @@ -2086,7 +2086,7 @@ void AchievementMgr::CompletedAchievement(AchievementEntry const* achievement)
            return;
    
        // titles
    -    if(uint32 titleId = reward->titleId[GetPlayer()->GetTeam() == HORDE ? 0 : 1])
    +    if(uint32 titleId = reward->titleId[GetPlayer()->GetTeam() == HORDE ? 1 : 0])
        {
            if(CharTitlesEntry const* titleEntry = sCharTitlesStore.LookupEntry(titleId))
                GetPlayer()->SetTitle(titleEntry);
    

  5. btw just curious is your trinitycore patch affecting the server performance, lately if the server reaches 1000++ player, server tends to freeze and spikes alot, but after i removed the core patch, server running smooth even running to 1500++ player.

    please enlight me if you have some tips.

    I guess this happens because of player activity feature (feed): each time when player hits achievement / item / boss kill server writes this info into DB without delay. For example, if 25-ppl raid kills some boss at first time (everybody had earned the achievement), in 1 moment 50 inserts to DB will be executed - 25 for achievement feed and other 25 for boss kill feed. Instead of it, it should be placed in memory and save from Player::SaveToDB(). How implement it I don't know - my C++ experience is very bad. If someone can help, PM me.
    i get mba instead
    So why you are asking about this project in this thread?
  6. Really need use source code and recompile it?

    Nope, this version has XMLWriter package (I hope, it should be there).

    I really can't understand why the only thing you got is HTML code (which can not be there in no case). But I think that you should look at your webserver. Try to download some package like WAMP or Denwer and test Armory on new server.

    PS I hope you are not running under the IIS server?

  7. <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
    <HTML dpieagent_htmladvised="true" dpffagent_docid="87156276" lpcachedff="0" 
    lpcachedffnumforms="0"><HEAD>
    <META content="text/html; charset=utf-8" http-equiv=Content-Type></HEAD>
    <BODY></BODY></HTML>

    Is your PHP compiled with XMLWriter package? Try to open url http://armory_url/?_DISPLAYVERSION_ it should display current revision in XML format. If not, then you should recompile PHP. Read this for more info.
  8. any chance you will put the file somewhere else?
    If you know free file share server (without ads and FTP access support), please, post link here and I'll upload archive there.
    My conf file

    $ArmoryConfig['multiRealm'][1]['id']                 = 2;

    realm index ([1]) should be equal to ['id'] value and must starts from 1. That means, you need to chage 2 to 1 ('id' value).

    About loading bar stuck - look at your Apache error log, there must be some info about missing textures.

    Does this happens only with current character or you unable to see any character's model?

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use