Elixir of water walking - warriors are unable to use. " invalid target "

[stickynicky21]

Hi there,

 

When I attempt to use "Elixir of Water Walking" on a Warrior I am prompted with the "Invalid Target" dialogue. 

Is anyone able to tell me how to fix this?

 

Many thanks

[Olion]

The spell fails at Spell::CheckCast() this way:

case SPELL_AURA_WATER_WALK:
{
...
    if (expectedTarget->GetTypeId() == TYPEID_PLAYER)
    {
       Player const* player = static_cast<Player const*>(expectedTarget);
                    
       // Player is not allowed to cast water walk on shapeshifted/mounted player 
       if (player->GetShapeshiftForm() != FORM_NONE || player->IsMounted())
           { return SPELL_FAILED_BAD_TARGETS; }
    }
 }

since warrior stances are considered as shapeshifts (FORM_BATTLESTANCE etc.) The fix depends on the desired behaviour:

• may the spell be cast on a warrior in a stance? is it possible to drop the stance at all?
• must the aura be dropped if warrior switches from no-stance to a stance?
• the same questions on the druid, priest (shadowform), and rogue (stealth)

The simplest way to fix it specifiacally for the warrior is to augment the shapeshift check by class check.

[stickynicky21]

Hey, Olion.

Sorry for the beyond late reply! I forgot I even asked this question. 

You are far wiser than myself, I am a beginner and currently have zero idea of how to do what you recommended. Sorry for sounding dumb but how would I go about augmenting the shapeshift check by class check?

 

Many many thanks!

 

 

[Olion]

There is Unit::getClass() method, inherited by the Player class, and enum Classes.

You might find a similar check, for example, here. Then it is all about basic C++ syntax.