Jump to content

[patch][8958] Mind Sear,Mind Flay proc triggers


Auntie Mangos

Recommended Posts

What bug does the patch fix? What features does the patch add?

Mind Sear,Mind Flay cannot trigger proc at the moment, thus cannot invoke vampiric embrace healing. Possibly some other triggers ( none that I have in mind now )

For which repository revision was the patch created?

7517

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

http://getmangos.eu/community/viewtopic.php?id=5772

http://getmangos.eu/community/viewtopic.php?id=6081

diff --git a/src/game/Spell.cpp b/src/game/Spell.cpp
index bbbaba9..c1aa949 100644
--- a/src/game/Spell.cpp
+++ b/src/game/Spell.cpp
@@ -747,8 +747,8 @@ void Spell::PrepareDataForTriggerSystem()
            case SPELLFAMILY_WARLOCK: // For Hellfire Effect / Rain of Fire / Seed of Corruption triggers need do it
                if (m_spellInfo->SpellFamilyFlags & 0x0000800000000060LL) m_canTrigger = true;
            break;
-            case SPELLFAMILY_PRIEST:  // For Penance heal/damage triggers need do it
-                if (m_spellInfo->SpellFamilyFlags & 0x0001800000000000LL) m_canTrigger = true;
+            case SPELLFAMILY_PRIEST:  // For Penance,Mind Sear,Mind Flay heal/damage triggers need do it
+                if (m_spellInfo->SpellFamilyFlags & 0x0009800000800000LL) m_canTrigger = true;
            break;
            case SPELLFAMILY_ROGUE:   // For poisons need do it
                if (m_spellInfo->SpellFamilyFlags & 0x000000101001E000LL) m_canTrigger = true;

Those are pretty ugly hacks in Spell::PrepareDataForTriggerSystem(), are you sure those are necessary?

I was trying to find something that makes all procs which allow other procs off them unique and it looks like those always have SpellFamilyFlags set.

Wasn't able to find a single proc which shuldnt proc and have SpellFamilyFlags. It makes sence, if you set family flags you do want it to be affected by others.

Take care.

Link to comment
Share on other sites

  • 39 years later...
  • 7 months later...
Guest
This topic is now closed to further replies.
×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use