[fix][7661] Cheat/Exploit: "godmode"

[Auntie Mangos]

What bug does the patch fix? What features does the patch add?

This patch fixes a bug where you get healed from mage's Polymorph if you first transform yourself using Orb of Deception even when Polymorph effect fades. It's like having uber heal over time on yourself, you can solo everyone and everything.

For which repository revision was the patch created?

Any repository, i personally use 7641.

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

http://getmangos.eu/community/viewtopic.php?id=7047

Who has been writing this patch? Please include either forum user names or email addresses.

False.Genesis

http://github.com/fgenesis/mangos/commit/515255f0dacea467b36a96be41d9430803257151

If used, this bug is quite game-breaking, it's like having uber-heal over time on yourself but without any buff so noone can see that.

This is a workaround, i put it here anyway for other people to use and to let developers know about this so they can fix it, i didn't have any response in the bug reporting section. I hope developers or someone else can make a proper patch for this and for anything similar in the code. Thanks to False.Genesis for the patch.

Thank you

[The_Game_Master]

No need for a workaround, just identify why this is not returning the proper aura.

Unit::AuraList const& otherTransforms = m_target->GetAurasByType(SPELL_AURA_TRANSFORM); 
       if(otherTransforms.empty())

[Graftal]

Well, this is also why i put a thread here, maybe someone can help, i'm not really so good with this yet, but i think this is quite a bad bug, and it's also known in the wow exploiting underground, so it's better to fix it asap and put it in the official branch, i need some help here

[False.Genesis]

fixed in my repo: http://github.com/fgenesis/mangos/commit/515255f0dacea467b36a96be41d9430803257151

i consider this patch as a hack so i didnt post it

[Graftal]

fixed in my repo: http://github.com/fgenesis/mangos/commit/515255f0dacea467b36a96be41d9430803257151

i consider this patch as a hack so i didnt post it

Yep, that's exactly what i linked in the first place in the topic

[VladimirMangos]

Patch apllied with some changes in [7661]. Thank you

Why review patch I see that we use getTransForm() only for negative spells checks (including all polymorth, right?)

So maybe we need set it only in case negative spell. This can let simplify all related code.