[Help] Implementing Vehicles

[Anti]

//VF_HAS_FUEL                     = 0x0100,                   // TODO : find out what energy type is fuel and implement this

This is used for example in Ulduar vehicles I think...(on TC2 it works, I think we can inspire..)

As i said: When you spawn vehicle(.npc add) its not vehicle, but normal creature.

Flying vehicles does not work? I tried frost wyrm from DK start location, and it cant fly. Maybe just wrong movement type, on rastikzzz's patch it worked fine

Accessories is not complete, when vehicle dies accessory not, etc(but Im working on this)

Thats all I found...

Well, I should do the same

ok i'll try to implement HAS_VUEL flag.

[ArtUrlWWW]

What is the TC2???

May be TC2 - it's repo? If yes, what is the TC2 URL to download?

[Anti]

ROFL

To google "TrinityCore2"

[ArtUrlWWW]

ROFL

To google "TrinityCore2"

Good, but TC2 is for the 3.1.3 version client? And in TC2 repo haven't file src/gave/Vehicle.cpp

Where is his vehicle source?

[Anti]

I writen "We can port wintergrasp from trinity for a tests" and it was to Wojta.

[Wojta]

SESSION: opcode CMSG_CHANGE_SEATS_ON_CONTROLLED_VEHICLE (0x049B) have unprocessed tail data (read stop at 40 from 74)

I get this when I try to change seat in vehicle with accessory. Where is packet size defined? Where can I set to ignore this?

[Anti]

After 1.5 hours of debugging I have come to next conclusion: We have to rewrite CMSG_CHANGE_SEATS_ON_CONTROLLED_VEHICLE handler in more correctly way.

The errors appears cauze we try to change our place in a vehicle being in other vehicle (Accessory).

TODO: Accesoryes can turn but not move.

[roby10]

why can't you improve rastikzzz's patch it is still 3.0.9/3.1.3 (not sure) it was one the best patches released

[Mr.Grom]

After this commit patch vehicle don't work normal.

[8710] Make vehicle guid counter per-map local.

[Thyros]

is not good reason to convert tc2 chanegs to mangos, tc2 is on 3.1.3!

[andriuspel]

is not good reason to convert tc2 chanegs to mangos, tc2 is on 3.1.3!

http://bitbucket.org/mateo0169/trinitycore2_322a/overview/ 3.2.2a experimental

[Anti]

why can't you improve rastikzzz's patch it is still 3.0.9/3.1.3 (not sure) it was one the best patches released

Rather artful patch I need some times to understand how it work.

The main problem is, that vehicles are creatures. We need to discuss it and choose a right way to implement a vehilces.

We must spawn vehicle, not creature. May be smbd knows a right way to implement it.

[Wojta]

TODO: Accesoryes can turn but not move.

And...thats wrong? I mean they are in seats, so they move with vehicle...

The main problem is, that vehicles are creatures. We need to discuss it and choose a right way to implement a vehilces.

We must spawn vehicle, not creature. May be smbd knows a right way to implement it.

It looks like base idea of current patch is wrong

[Anti]

And...thats wrong? I mean they are in seats, so they move with vehicle...

It looks like base idea of current patch is wrong

In our realization they cann't turn but in offi it does.

http://www.youtube.com/watch?v=ChQ36IYau_c

May be we can take some changes in spawn system...

[Wojta]

You mean that in this patch they cant turn? But for me it works...not with WASD, but try to hold both mouse buttons and move with it...

[Anti]

You mean that in this patch they cant turn? But for me it works...not with WASD, but try to hold both mouse buttons and move with it...

So strange cauze I pulled the vehicle branch from your git and didn't change any movement flags.

[Wojta]

http://one-b1og.eu/vehicle/ ... ?

BTW looks like we have to start from beginning, I just hope we have enough knowledge

[Anti]

I have the qustions for a devs or a knowledge peolpes.

How to make strongly connection between spawn and npc? I'd try to implement it by including the new condition in respawn()

if (isVehicle() && isAlive()) return;

in respawn() but it failed.

Oh god, a minute passed After I posted my question and I obtained the answer.

When we click on a vehicle it constructing a new one. And we obtain the vehicle.

But spawn became free. And it call to respawn.

I wish to connect a vehicle and it's spawn.

May be we can overwrite isAlive func for the vehicle's class or do smth else in this way.

[Rescript]

Kind time of the days, Respected.

I will ask the help to instal to me this patch on "8932" version of acore. There are errors at flood filling. I ask a pardon for my English. Has read many posts and messages, but has not understood. In advance thanks! To me it is very important.

[gen1us2k]

Kind time of the days, Respected.

I will ask the help to instal to me this patch on "8932" version of acore. There are errors at flood filling. I ask a pardon for my English. Has read many posts and messages, but has not understood. In advance thanks! To me it is very important.

git clone git://github.com/mangos/mangos.git
cd mangos
git checkout -b vehicle
git pull git://github.com/Tasssadar/Valhalla-Project.git vehicle
git diff -p master vehicle > vehicle.patch
cp vehicle.patch ../path/to/your/patches
git checkout master
patch -p1 -l < ../path/to/your/patches/dualspec.patch
patch -p1 -l < ../path/to/your/patches/vehicle.patch

I do so...

[Wojta]

http://bitbucket.org/KingPin/trinitycore2/changeset/3cc19474e78c/

Wintergrasp: on trinity its done like OutdoorPvP, so it wont be so easy to port it to mangos....

[gen1us2k]

Im recompiled 5 times... doesn't work... maybe i do anything wrong ,,, Ok I test now another way

[Anti]

Some proofs special for you:

It's no very hard to implement Silver Tournament or few new vehicles.

[gen1us2k]

but... I understood one thing.

I got a clean source... Then

git pull git://github.com/Tasssadar/Valhalla-Project.git vehicle

then

patch -p1 -l <dua.patch

now compiling... then testing...

and I notices 3-4 SQL errors,,,

but a made vehicle.pacth as diff master vehicle....

Well ... see how It Will work

sorry for my bad English

is difference as I apply updates from vehicles previous to MaNGOS updates or not?

[petbat]

Here's a SQL of VEHICLES! Tested only with TC2 patch 3.2.2a

http://subversion.assembla.com/svn/TrinityDB/Custom/Vehicle/