[fix][7943] Fear to stunned target

[Corfen]

What bug does the patch fix? What features does the patch add?

This patch fixes fear effects to stunned target.

Stunned target shouldn't be immune to fear effects.

For which repository revision was the patch created?

7936

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

I didn't find thread with this problem.

Who has been writing this patch? Please include either forum user names or email addresses.

Me (Corfen)

core patch:

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index e1a46f1..de733fe 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -8415,13 +8415,6 @@ bool Unit::IsImmunedToSpell(SpellEntry const* spellInfo)
    if (!spellInfo)
        return false;

-    //FIX ME this hack: don't get feared if stunned
-    if (spellInfo->Mechanic == MECHANIC_FEAR )
-    {
-        if ( hasUnitState(UNIT_STAT_STUNNED) )
-            return true;
-    }
-
    //TODO add spellEffect immunity checks!, player with flag in bg is imune to imunity buffs from other friendly players!
    //SpellImmuneList const& dispelList = m_spellImmune[iMMUNITY_EFFECT];

Patch file

[hunuza]

Committed in [7943]. Thank you.

[VladimirMangos]

//FIX ME this hack: don't get feared if stunned

And where fix _real_ problem_ that prevented by this _know_ hack.

As i remember in past exist probelms with stacking this effects with crash and srange work possibilities...

[hunuza]

As far as I can remember I already removed similar checks years ago.

I just probably forgot that one.

[VladimirMangos]

Hmm, as i remember source problems not resolved... but i not re-check, sorry. So maybe i just have CRC errors in memory

[leak]

Could someone backport it please?

[pelle]

Hmm, as i remember source problems not resolved...

yep still bugged, stunned immune to fear.

[napalm]

yep still bugged, stunned immune to fear.

I heard many ppl that this is how it works on offi ... Stunned ARE immune to fear.

[dardennf]

yep still bugged, stunned immune to fear.

What REV are you using ?

I heard many ppl that this is how it works on offi ... Stunned ARE immune to fear.

No you should be "FEAR" even if you are Stunned .

[pelle]

What REV are you using ?

No you should be "FEAR" even if you are Stunned .

7948. i tried to stun and fear but i got immune.

btw im going to update soon to latest (7983) so i'll test again.

[Kotake]

I heard many ppl that this is how it works on offi ... Stunned ARE immune to fear.

And how are your supposed to chain cast Shadowfury with Howl of terror?

asd

[napalm]

Ok, they should be "FEAR" but don't move while the stun effect is up.

[dardennf]

Yes, exactly.

[pelle]

Ok, they should be "FEAR" but don't move while the stun effect is up.

yes. so does this patch work? for me at the moment no...

[Corfen]

yes. so does this patch work? for me at the moment no...

I have rev8016 now and works.

[pelle]

I have rev8016 now and works.

but what branch?

[Corfen]

but what branch?

Master branch.