[Patch][7974] Implemented T_LEVEL and T_GENDER createria type data

[Thyros]

What bug does the patch fix? What features does the patch add?

- Added ACHIEVEMENT_CRITERIA_DATA_TYPE_T_LEVEL and ACHIEVEMENT_CRITERIA_DATA_TYPE_T_GENDER, write by Thyros and Dyddye

For which repository revision was the patch created?

- 7952

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

- nothing found

Commit:

http://github.com/Thyros/cwcore/commit/f06f38ba5f355885ff36d6b7e35ce56a2fad5cd7

Patch: http://filebeam.com/fac5504ba5fc55669e03437fb5b667b8

[Thyros]

no comment?

[Wast3d]

How about .patch file ^^

[Thyros]

How about .patch file ^^

Patch added

[Wast3d]

Works for me Great

[paytheo]

which achievement is this for ?

[Thyros]

Level and Gender Check, for rabbit

[VladimirMangos]

achievement id that required this checks?

[Thyros]

achievement id that required this checks?

yeah is required, and works fine vladimir

[Ceris]

yeah is required, and works fine vladimir

but I think Vladimir wants to know, for which achievements is this check required

[VladimirMangos]

Yes. Ceris, thanks for clarify.

[Thyros]

Yes. Ceris, thanks for clarify.

it is checked whether the male or female class or level 18 is, this is the necessary

[VladimirMangos]

Grrr.. I can read code and understand what this check do, but in what exactly achievement this need?

[nos4r2zod]

Level 18? Gender dependent? Do you mean http://www.wowhead.com/?achievement=2422 ?

[VladimirMangos]

Ah, Thanks! Get it now... I accept patch and will add but before i need implement related achievement support and

it can be added only to master 310 branch...

When suggest patch for not master btanch _always_ pleas provide info about this...

[Thyros]

Level 18? Gender dependent? Do you mean http://www.wowhead.com/?achievement=2422 ?

yeah its right

Ah, Thanks! Get it now... I accept patch and will add but before i need implement related achievement support and

it can be added only to master 310 branch...

When suggest patch for not master btanch _always_ pleas provide info about this...

Works on Master Vladimir

[VladimirMangos]

From changes:

1) used in achievment code code style required use achievement criteria data type specific record instead raw fields.

2) player checks not required for gender/level. this checks can be used with creatures also.

In discussedf achievment exist race requiredment that have player limitation so all ok.

Added to 310 branch with this changes. Thank you

[Thyros]

thanks vladimir for add this to 310

[DerDyddye]

Hi @ all,

i hope you enjoy my update.

Description:

`mangos`.`achievement_criteria_data`

Target_MinLevel (player only)
`type`=9 and `value1`= MINLEVEL

Target_Gender (player only)
`type`=10 and `value`= GENDER
MALE=0 ; FEMALE=1

Here is missing sql for some achievements:

a1685 - 2 (male player)

a2422 - Shake Your Bunny-Maker (all: race ; minlevel 18; female)

a2576 - Blushing Bride (female player)

DELETE FROM `achievement_criteria_data` WHERE `criteria_id` in (6227,9124,9143,9144,9145,9146,9147,9148,9149,9150,9151,9858);
INSERT INTO `achievement_criteria_data` VALUES
(6227,10,0,0),
(9124,2,0,10),
(9124,9,18,0),
(9124,10,1,0),
(9143,2,0,11),
(9143,9,18,0),
(9143,10,1,0),
(9144,2,0,1),
(9144,9,18,0),
(9144,10,1,0),
(9145,2,0,3),
(9145,9,18,0),
(9145,10,1,0),
(9146,2,0,7),
(9146,9,18,0),
(9146,10,1,0),
(9147,2,0,4),
(9147,9,18,0),
(9147,10,1,0),
(9148,2,0,2),
(9148,9,18,0),
(9148,10,1,0),
(9149,2,0,6),
(9149,9,18,0),
(9149,10,1,0),
(9150,2,0,8),
(9150,9,18,0),
(9150,10,1,0),
(9151,2,0,5),
(9151,9,18,0),
(9151,10,1,0),
(9858,10,1,0);

===

@Thyros: Next time ask me before you share my code

[XTZGZoReX]

DB data goes at your local DB provider's forum .

[VladimirMangos]

Thyros: Next time ask me before you share my code

DerDyddye, sorry if this patch writed by you. I add topic starter because not any other author refereces in thread and in commit in pointed git repo. Normally whencommits added into own/project repo in git author expected to set to original patch author.

About DB data:

Mangos team not fill this table in mangos sql files version. More, in most case we strongly against publishing at forum data for like tables.

[VladimirMangos]

Publish like patch to brabch has been wrong idea: we need full existed dta types in master.

Patch backported to master as [7974] with updated author.

[Thyros]

i have help for this -.-

[VladimirMangos]

Just next time explicitly write who author of patch, please.

Thyros: Next time ask me before you share my code

Note: All patches writed base at GPL sources itself have GPL license.

Base at GPL license not need ask anyone for agreement share like patches.

Only authorship information need preserved.