Jump to content

Recommended Posts

Posted

I've updated the code in post #36 for a crash fix. Happens sometimes in outdoor zone since some patchs when wearing one of those tabard and farming reputation giving mobs

for the record, it's the "pVictim->GetMap()->IsDungeon()" on the "if (HasAura(57818))" line

  • Replies 56
  • Created
  • Last Reply

Top Posters In This Topic

  • 3 months later...
Posted

Rev. 10352 - can not compile

Error 66 error C2664: 'Player::CalculateReputationGain' : cannot convert parameter 1 from 'uint32' to 'ReputationSource' d:\\Servers\\Server_WoW\\MaNGOS\\src\\mangos_latest\\Mangos_r10352+sd2r1777+patches\\src\\game\\Player.cpp 6378 game
  • 1 month later...
  • 3 weeks later...
  • 4 months later...
Posted

It's affected by the creature_rate in reputation_reward_rate table, and from the numbers i got in IRC a while ago (you were actually there too ^^), the Alliance Vanguard rep. is actually the wrong one, it should get the +30% boost from patch 3.3.something too, however its subfaction apparently not, which is not possible in current code...

seems at retail these rates are applied as very last step, but then we have to wipe the possibility to have different values for quest, creatures and spells basically...

Guest
This topic is now closed to further replies.
×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use