[8043]skill discovery TYPO

[rastikzzz]

What bug does the patch fix? What features does the patch add? : fix currently not working skill discovery and fix crash at empty skill discovery table

For which repository revision was the patch created? : 8029 (latest)

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. : didint find any

Who has been writing this patch? : me

in skilldiscovery.cpp is

@@ -52,11 +52,11 @@ void LoadSkillDiscoveryTable()
    uint32 count = 0;

    //                                                0        1         2              3
    QueryResult *result = WorldDatabase.Query("SELECT spellId, reqSpell, reqSkillValue, chance FROM skill_discovery_template");

-    if (result)
+    if (!result)
    {
        sLog.outString();
        sLog.outString( ">> Loaded 0 skill discovery definitions. DB table `skill_discovery_template` is empty." );
        return;
    }

link http://github.com/rastikzzz/mangos/commit/45cc0b13773dafd912b096105a56264a10fe7413

[KAPATEJIb]

patch

diff --git a/src/game/SkillDiscovery.cpp b/src/game/SkillDiscovery.cpp
index dbbbc48..9a76347 100644
--- a/src/game/SkillDiscovery.cpp
+++ b/src/game/SkillDiscovery.cpp
@@ -54,7 +54,7 @@ void LoadSkillDiscoveryTable()
    //                                                0        1         2              3
    QueryResult *result = WorldDatabase.Query("SELECT spellId, reqSpell, reqSkillValue, chance FROM skill_discovery_template");

-    if (result)
+    if (!result)
    {
        sLog.outString();
        sLog.outString( ">> Loaded 0 skill discovery definitions. DB table `skill_discovery_template` is empty." );

[Lynx3d]

Hm does that actually fix discovery for you?

It is now loading the table, but i get errors like

Loading Skill Discovery Table...
ERROR:Spell (ID: 61288) not have have MECHANIC_DISCOVERY (28) value in Mechanic field in spell.dbc and not 100% chance random discovery ability but listed for spellId 57209 (and maybe more) in `skill_discovery_template` table
ERROR:Spell (ID: 61177) not have have MECHANIC_DISCOVERY (28) value in Mechanic field in spell.dbc and not 100% chance random discovery ability but listed for spellId 56944 (and maybe more) in `skill_discovery_template` table
ERROR:Spell (ID: 60893) not have have MECHANIC_DISCOVERY (28) value in Mechanic field in spell.dbc and not 100% chance random discovery ability but listed for spellId 53895 (and maybe more) in `skill_discovery_template` table

And minor inscription research still does nothing.

I'm using MaNGOS 0.14 [8040] with UDB 0.11.5 (381)

I've seen someone post those errors on UDB forums too, but no reply yet.

[goodbadguy]

Doesn't fix the broken in-game skill discovery...

[dereka]

in [8043]rev, thanks