[Fix][8509] Savage Defense and Sacred Shield Coefficients

[nos4r2zod]

What bug does the patch fix? What features does the patch add?

This adds the respective coefficients for the triggered spells of Savage Defense and Sacred Shield. Also added a check in IsNoStackSpellDueToSpell to allow Frenzied Regeneration to stack with Savage Defense (they have the same icon).

For which repository revision was the patch created?

8428

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

Didn't find any

Who has been writing this patch? Please include either forum user names or email addresses.

Myself

Patch

EDIT (7-14): Implemented charges for Savage Defense, should disappear after absorbing one hit.

EDIT (8/28): Updated to 8428, dropping the code that was independently implemented already.

[Sephiroth1983]

Can't you add the coefficients using spell_bonus_data table?

[nos4r2zod]

Aura::HandleSchoolAbsorb doesn't use spell_bonus_data, and Power Word : Shield, Frost Ward, Fire Ward, ice Barrier, and Shadow Ward all use hard coded values.

[Sephiroth1983]

Aura::HandleSchoolAbsorb doesn't use spell_bonus_data, and Power Word : Shield, Frost Ward, Fire Ward, ice Barrier, and Shadow Ward all use hard coded values.

No, check again spell_bonus_data, the only exceptions (or missing records in the table) are Frost Ward and Fire Ward.

[nos4r2zod]

Well they shouldn't have coefficients in that table then, because the coefficients there don't add anything. Check where GetSpellBonusData is being called in the code; only in Unit::SpellDamageBonus and Unit::SpellHealingBonus.

Aura::HandleSchoolAbsorb's hardcoded coefficients only call SpellBaseHealingBonus and SpellBaseDamageBonus because they aren't affected by buffs that modify healing percent, like wound poison or tree of life aura.

[nos4r2zod]

Updated past 8428, which implemented the attack power bonus of Savage Defense; parts of this patch are still usable.

[VladimirMangos]

In [8509]. Thank you