[Fix] Triggered Spell Mechanics and Miss Chance

[Auntie Mangos]

What bug does the patch fix? What features does the patch add?

• * Added a "canMiss" flag which is set to false when the spell is triggered, but not from a proc. This prevents miss chance from being factored in multiple times when calculating miss for Judgements, Stormstrike, Mutilate, Whirlwind. These should only have one miss roll.
  * Fixed the miss chance of SPELL_DAMAGE_CLASS_RANGED spells so that spells that don't really use a ranged weapon (meaning they don't have SPELL_ATTR_RANGED) always use max skill. (This includes judgements and blind)
  * Also made the scripted spell triggered by Chimera Shot count as a triggered spell.
  

For which repository revision was the patch created?

8379

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

Judgement miss chance - http://getmangos.eu/community/viewtopic.php?id=8131

Freezing Arrow - http://getmangos.eu/community/viewtopic.php?id=6923

Who has been writing this patch? Please include either forum user names or email addresses.

Myself

Patch

[pelle]

will be reverted tp 0.12?

[thenecromancer]

I'm sure that some spells that are done using triggered spells have unique attributes ( there was some shared attribute for judgements and execute in 2.4.3 for example ) please check that first

[VladimirMangos]

EDIT: obsolete!)

Meaning: must be moved to rejected as outdated?

[nos4r2zod]

Meaning: must be moved to rejected as outdated?

Actually, I meant to say that it's not up to date and I haven't tested it since 8193, but I think the bugs covered still persist.

Edit: Updated for 8379. Maybe there's a better way to do

+    // Procs can miss, weapon enchants can miss, triggered spells and effects cannot miss (miss already calculated in triggering spell)
+    bool canMiss = (m_triggeredByAuraSpell || !m_IsTriggeredSpell);

though, it's too strict in that it requires scripted spells triggered from auras to NOT have a m_triggeredByAuraSpell for this spell to work (like Judgements as triggered from Seals, or Chimera Shot as triggered from stings).

Also, removed the cooldown hack in this patch, wasn't really related, and perhaps a better way to have done would have been in the AddSpellAndCategoryCooldowns, like this.

[przemratajczak]

i am using it (mangos master 8372) and works as intended, without problem

[JordanMckeag]

Apply this patch we need this commiting

[VladimirMangos]

Maybe some flag exist in spell data... Ofc, possible add special arg to cast function and send into main spell entry for make difference casted subspell from main spell from just script casted boss spell, but for example exist spell do oofhand attack and it expected to have own miss chance...

I also think that

bool canMiss = (m_triggeredByAuraSpell || !m_IsTriggeredSpell);

too strong, and m_IsTriggeredSpell originally only meaning that this not client side cast and then it not get spell casting slot for caster. Why and from what it triggred not defined...

[jorooo]

All bugs still persist. Would be nice if this gets accepted

[darkstalker]

maybe check if the spell is triggered by the current casting spell?

[przemratajczak]

how about procChane 101?

[darkstalker]

how about procChane 101?

always wondered what does that "proc chance 101%" mean

[False.Genesis]

is this patch still required / bugs still there? anyone have some idea..?

[przemratajczak]

afaik nothing was done

[Morphau]

Bumps, any patch for corect Judgement please ?

[KAPATEJIb]

for 9564 http://paste2.org/p/710458 or http://github.com/insider42/mangos/commit/5eda5906a4fcdd1e88452b1843e3ebea7d25cf18

[KAPATEJIb]

for 9688 http://paste2.org/p/761466 or http://github.com/insider42/mangos/commit/b5aa2a036aee9ecf8f4310f90aed93e56881d6e7

[jenjena]

this problem still exists can some one update it.