[Patch] NotActiveMover wrong concept

[Opterman]

What bug does the patch fix? What features does the patch add?

Fix CMSG_MOVE_NOT_ACTIVE_MOVER , maybe a typo

For which repository revision was the patch created?

8432

Who has been writing this patch? Please include either forum user names or email addresses.

Me

This is the patch:

From b132ef74014bc1653f46918742d7f77ed4d26d35 Mon Sep 17 00:00:00 2001
From: unknown <Administrator@.(none)>
Date: Sun, 30 Aug 2009 18:12:56 -0700
Subject: [PATCH] NoActiveMover

---
src/game/MovementHandler.cpp |    9 ++++-----
1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/game/MovementHandler.cpp b/src/game/MovementHandler.cpp
index 7696e1e..2c2ec80 100644
--- a/src/game/MovementHandler.cpp
+++ b/src/game/MovementHandler.cpp
@@ -446,14 +446,13 @@ void WorldSession::HandleSetActiveMoverOpcode(WorldPacket &recv_data)
void WorldSession::HandleMoveNotActiveMover(WorldPacket &recv_data)
{
    sLog.outDebug("WORLD: Recvd CMSG_MOVE_NOT_ACTIVE_MOVER");
-    recv_data.hexlike();

-    uint64 old_mover_guid;
-    recv_data >> old_mover_guid;
+    uint64 mover_guid;
+    recv_data >> mover_guid; //GUID That disable movement

-    if(_player->m_mover->GetGUID() == old_mover_guid)
+    if(_player->m_mover->GetGUID() != mover_guid)
    {
-        sLog.outError("HandleMoveNotActiveMover: incorrect mover guid: mover is " I64FMT " and should be " I64FMT " instead of " I64FMT, _player->m_mover->GetGUID(), _player->GetGUID(), old_mover_guid);
+        sLog.outError("HandleMoveNotActiveMover: incorrect mover guid: mover is " I64FMT " and should be " I64FMT " instead of " I64FMT, _player->m_mover->GetGUID(), _player->GetGUID(), mover_guid);
        recv_data.rpos(recv_data.wpos());                   // prevent warnings spam
        return;
    }
-- 
1.6.2.msysgit.0.186.gf7512

The old processing code of this packet was a bit annoying because mover guid was as old mover guid perhaps meaning that when client send no active mover packet, mover guid change and that's no right. and before appliying my fix in my server i got very weird console messages like these:

HandleMoveNotActiveMover: incorrect mover guid: mover is 000000000005DD12 and should be 000000000005DD12 instead of 000000000005DD12

HandleMoveNotActiveMover: incorrect mover guid: mover is 000000000001B4CD and should be 000000000001B4CD instead of 000000000001B4CD

HandleMoveNotActiveMover: incorrect mover guid: mover is 000000000001C1D4 and should be 000000000001C1D4 instead of 000000000001C1D4

HandleMoveNotActiveMover: incorrect mover guid: mover is 0000000000013F6F and should be 0000000000013F6F instead of 0000000000013F6F

Greetings, Opterman

[cyrex]

I think i remember those errors and maybe i got some of them in the log. Will go to check it out (7MB log)

[Mordaunt]

I have a lot of these errors too. Thats why I was specifically searching the forum and found this. I checked the up-to-date code of Mangos and saw no changes like this patch suggested. Because the patch is here for quite some months now, is this patch still valid? Is this the good approach for fixing this issue?

[The_Game_Master]

Please move this to accepted, it's allready in repo.