[9494][patch] Spell effect 41

[qsa]

What bug does the patch fix? What features does the patch add?

"Implementing" Spell effect 41 - SPELL_EFFECT_JUMP

Just use same handler as Spell::EffectJump, // 42 SPELL_EFFECT_JUMP2

Can't see the difference - tested, it works pretty well.

id    spellname_0
51893    JumpUnittest
52043    JumpChargeUnitTest
52206    Leaping Face Maul
52328    Malleable Ooze
52631    Leaping Face Maul
53625    Heroic Leap
53679    Mograine's Charge
53705    Tirion's Charge
54272    Pounce
54468    Leaping Face Smash
54485    Magnetic Pull Alt
54487    Jump Attack
54507    Heroic Leap
54781    Frenzied Dive
55054    Varian Leap
55263    Harpy Dive
56113    Jump Attack
56729    Frenzied Leap
59008    Throat Rip
59790    Heartstrike
60642    Annihilate
61115    Belly Flop
64374    Savage Pounce
64478    Feral Pounce
64496    Feral Rush
64666    Savage Pounce
64669    Feral Pounce
64674    Feral Rush
64953    Jump Attack

For which repository revision was the patch created?

8542

Who has been writing this patch? Please include either forum user names or email addresses.

Me

diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp
index be73189..f1e5919 100644
--- a/src/game/SpellEffects.cpp
+++ b/src/game/SpellEffects.cpp
@@ -98,7 +98,7 @@ pEffect SpellEffects[TOTAL_SPELL_EFFECTS]=
    &Spell::EffectDispel,                                   // 38 SPELL_EFFECT_DISPEL
    &Spell::EffectUnused,                                   // 39 SPELL_EFFECT_LANGUAGE
    &Spell::EffectDualWield,                                // 40 SPELL_EFFECT_DUAL_WIELD
-    &Spell::EffectUnused,                                   // 41 SPELL_EFFECT_JUMP
+    &Spell::EffectJump,                                     // 41 SPELL_EFFECT_JUMP
    &Spell::EffectJump,                                     // 42 SPELL_EFFECT_JUMP2
    &Spell::EffectTeleUnitsFaceCaster,                      // 43 SPELL_EFFECT_TELEPORT_UNITS_FACE_CASTER
    &Spell::EffectLearnSkill,                               // 44 SPELL_EFFECT_SKILL_STEP

[cyrex]

Am not quiet as good as you but in this part:

&Spell::EffectDualWield, // 40 SPELL_EFFECT_DUAL_WIELD

- &Spell::EffectUnused, // 41 SPELL_EFFECT_JUMP

+ &Spell::EffectJump, // 41 SPELL_EFFECT_JUMP

&Spell::EffectJump, // 42 SPELL_EFFECT_JUMP2

Wont it have after it 2 EffectJump? what i mean is can you teach me the logic of having those two?

[qsa]

Am not quiet as good as you but in this part:

&Spell::EffectDualWield, // 40 SPELL_EFFECT_DUAL_WIELD

- &Spell::EffectUnused, // 41 SPELL_EFFECT_JUMP

+ &Spell::EffectJump, // 41 SPELL_EFFECT_JUMP

&Spell::EffectJump, // 42 SPELL_EFFECT_JUMP2

Wont it have after it 2 EffectJump? what i mean is can you teach me the logic of having those two?

I don't sure I understand the question.

All that change made it so both effect 41 and 42 will be handled using EffectJump() function.

The logic behind it is pretty simple, as far as I see there is no difference in the data on those effects and EffectJump() can handle them both without further changes.

[Sephiroth1983]

Thanks for all the structure patches you are sharing

[shane99]

I could not put it better

thank you so much !!

cheers

shane99

[qsa]

You better thank Mangos team permanent members, that do the real work, not me.

Cheers guys.

[cyrex]

@qsa - I see nice job.

[cyrex]

Kung Fu Bump!:eek:

[VladimirMangos]

In [9494]. Thank you