Jump to content

[patch][8627] cleanup in Object and ObjectAccessor


Guest SilverIce
 Share

Recommended Posts

deleted some unused and old functions

changed logic of Object::SendUpdateToPlayer function - no sense update object fields for all players around

(at SendUpdateObjectToAllExcept), because its already doing every world tick in ObjectAccessor::Update, so only create update packet building for object's viewer

at Player::UpdateVisibilityOf

       if(target->isVisibleForInState(this,viewPoint,false))
       {
           visibleNow.insert(target);
           target->BuildUpdate(data_updates);
           target->BuildCreateUpdateBlockForPlayer(&data, this);
           UpdateVisibilityOf_helper(m_clientGUIDs,target);

target->BuildUpdate(data_updates);

why not delete that function? it will call changed fields data building for all players around (here we must build only create data for viewer)

http://pastebin.ca/1588540

Link to comment
Share on other sites

why not delete that function? It will call changed fields data building for all players around (here we must build only create data for viewer)
Check 2 chars in one group trevel at boat.

Client in past has been sometime unhappy when data send in different order.

Also what about cases when one player in tick see another char but another not see first yet (update will send at next tick) and first char start attack another char.

Link to comment
Share on other sites

Check 2 chars in one group trevel at boat.

Client in past has been sometime unhappy when data send in different order.

Also what about cases when one player in tick see another char but another not see first yet (update will send at next tick) and first char start attack another char.

In case one player don't see another player(i.e. that player is not in visible guids) update fields data won't be created

Link to comment
Share on other sites

I meaning not see in _client_ but _must_ see, just client not recieved yet data.

In current state we make always send like update in same time (at least at server side), in you case more delay added including some code at server time calling... i worry about this.

I just suggest test some special cases when client crash in past dependent from updates order send: transports

Link to comment
Share on other sites

  • 2 weeks later...
 Share

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use