[fix][8732] Action Button saving

[darkstalker]

* What bug does the patch fix? What features does the patch add?

Fixes the problem that happens after deleting a spell from an action bar button and replacing it with another spell. The button gets flagged for deletion and that flag doesnt get removed after putting a new spell there, so any changes made get lost after the next player save. Usually happens after you respec and lose some spells from action bars, placing them again in their slots makes you lose them after relog.

* For which repository revision was the patch created?

8719

* Is there a thread in the bug report section or at lighthouse?

no

* Who has been writing this patch?

darkstalker

diff --git a/src/game/Player.h b/src/game/Player.h
index 5533110..4c9325d 100644
--- a/src/game/Player.h
+++ b/src/game/Player.h
@@ -161,7 +161,7 @@ struct ActionButton
    void SetActionAndType(uint32 action, ActionButtonType type)
    {
        uint32 newData = action | (uint32(type) << 24);
-        if (newData != packedData)
+        if (newData != packedData || uState == ACTIONBUTTON_DELETED)
        {
            packedData = newData;
            if (uState != ACTIONBUTTON_NEW)

[cyrex]

So it really was a bug. I was just thinking it was my imagination really.

Nice work.

[Lynx3d]

Yea i was really wondering if i am that spastic lately to randomly drag off action buttons without noticing.

Not sure if it's really this bug, but certain buttons just disappeared now and then, but not every login i think...pretty bad if it's one of those emergency buttons where you only notice it when you need it... *bites the dust*

[VladimirMangos]

In [8732]. Thank you