Overkill bug when you use Vanish

[nikko]

Mangos Version: 8480

Custom Patches: 3.1.3

SD2 Version: ScriptDev2 (for MaNGOS 8443+) - ScriptDev2 Rev. 1392

Database Name and Version: UDB 0.11.5 (382)

How it SHOULD work: While stealthed, and for 20 seconds after breaking stealth, you regenerate 30% additional energy. http://www.wowhead.com/?spell=58426 - http://www.wowhead.com/?spell=26889

How it DOES work: When you use Vanish you enter in Stealth but doens't put you Overkill Buff

[lakostem2]

Confirmed.

This should work same way Master of subtetly works, when you cast vanish (and you have MOS by talents) you gain vanish for 10 sec, steath and MOS . with Overkill, well that's another story : )

YES ! we all know vanish is bugged, we all know stealth is bugged too. but fixing this will give a little energy burst to muti rogues : )

[DLeonHeart]

please someone look itnto this, with mutilate damage bugged at least we need overkill working properly:(

[pelle]

i suggested this ( http://dev.trinitycore.org/trinitycore2/issue/899/fix-overkill-proc-after-vanish ) patch to trinity, should work on mangs too.

[KAPATEJIb]

taken from your last post

diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp
index 4f4b4b9..1929f1f 100644
--- a/src/game/SpellEffects.cpp
+++ b/src/game/SpellEffects.cpp
@@ -5668,6 +5668,9 @@ void Spell::EffectSanctuary(uint32 /*i*/)
    if(m_spellInfo->SpellFamilyName == SPELLFAMILY_ROGUE && (m_spellInfo->SpellFamilyFlags & SPELLFAMILYFLAG_ROGUE_VANISH))
    {
        ((Player *)m_caster)->RemoveSpellsCausingAura(SPELL_AURA_MOD_ROOT);
+        // Overkill 
+        if(((Player*)m_caster)->HasSpell(58426))
+            m_caster->CastSpell(m_caster, 58427, true);
    }
}

[DLeonHeart]

taken from your last post

diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp
index 4f4b4b9..1929f1f 100644
--- a/src/game/SpellEffects.cpp
+++ b/src/game/SpellEffects.cpp
@@ -5668,6 +5668,9 @@ void Spell::EffectSanctuary(uint32 /*i*/)
    if(m_spellInfo->SpellFamilyName == SPELLFAMILY_ROGUE && (m_spellInfo->SpellFamilyFlags & SPELLFAMILYFLAG_ROGUE_VANISH))
    {
        ((Player *)m_caster)->RemoveSpellsCausingAura(SPELL_AURA_MOD_ROOT);
+        // Overkill 
+        if(((Player*)m_caster)->HasSpell(58426))
+            m_caster->CastSpell(m_caster, 58427, true);
    }
}

could you post it as a fix in order to get this into the next revision?

ty in advance.

cheers

[nikko]

Doesn't work

[pelle]

works on trinity btw., should work on mangos too.

[DLeonHeart]

with insider42 repo it works but it doesnt refresh the buff if you already had it by the time you vanish.

example: you leave stealth, and you have overkill buff, so you vanish and the buff disappears after a while even if you dont leave stealth, even if you remove the buff beofore vanishing.

[nikko]

Indeed, you are right