[patch] Not apply enchant's bonuses if require skill/level

[Wowka321]

What bug does the patch fix? What features does the patch add?

Some enchants require profession skills or player's level to activate bonuses from enchant.

e.g.

Fractured Dragon's Eye

Enchant Weapon - Blade Ward

Socket Bracer

and more...

Requirements exist in DBC, so what can't use this?

May be better move this check into

EnchantmentFitsRequirements

...

For which repository revision was the patch created?

master branch (3.3.3a)

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

--

Who has been writing this patch? Please include either forum user names or email addresses.

me - Wowka321

http://paste2.org/p/844616

Update. Now stats properly add \\ remove with skill changes.

[Veretos]

I am having the following problem applying the patch on the current revision:

error: patch failed: src/game/DBCStructure.h:1522
error: src/game/DBCStructure.h: patch does not apply
error: patch failed: src/game/DBCfmt.h:86
error: src/game/DBCfmt.h: patch does not apply
error: patch failed: src/game/Player.cpp:11874
error: src/game/Player.cpp: patch does not apply

[Lynx3d]

I really don't know what you guys are doing wrong all the time, the patch applies just fine to [8812] over here...

How many mistakes can you do with copy, paste and safe? :confused:

[Veretos]

I really don't know what you guys are doing wrong all the time, the patch applies just fine to [8812] over here...

How many mistakes can you do with copy, paste and safe?

How can you make a mistake in spelling save?

To: Wowka321

Great patch I applied it manually and seems to work well from few test. I noticed that when you have the enchant and you unlearn the skill the bonus will stay until you relog. Not sure if that is how it's intended might be something you need to take a look at.

[LordJZ]

I guess he's having problems with line endings

[Veretos]

I guess he's having problems with line endings

I removed the -- at the end of the patch file still doesn't seem to work even tried to apply it on a clean branch.

[Wowka321]

Update. Fix possible exploit.

[zergtmn]

Update. Fix possible exploit.

Players will lose HP and mana on each skillup.

[Wowka321]

Players will lose HP and mana on each skillup.

yea, you are right. =\\ So any ideas how to check and reapply bonuses if need?

[zergtmn]

yea, you are right. =\\ So any ideas how to check and reapply bonuses if need?

1. Disable enchants that require skill before removing that skill

2. Enable enchants that require skill after skillup (and enchants that have minimal level after levelup) if their requirements become satisfied.

I'm too lazy to fix it, so I reapply all enchants

[Wowka321]

Updated )

Now it's checked where possible)), BTW check in lvl i think not need, exploit not possible in real game here.