[fix][8986] Resilience on periodic crits

[darkstalker]

* What bug does the patch fix? What features does the patch add?

Implements critical strike damage reduction for periodic damage over time spells.

* For which repository revision was the patch created?

8904

* Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

dont know anyone

* Who has been writing this patch? Please include either forum user names or email addresses.

darkstalker

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index 9a65053..73331a5 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -6439,7 +6439,11 @@ void Aura::PeriodicTick()

            // send critical in hit info for threat calculation
            if (isCrit)
+            {
                cleanDamage.hitOutCome = MELEE_HIT_CRIT;
+                // Resilience - reduce crit damage
+                pdamage -= m_target->GetSpellCritDamageReduction(pdamage);
+            }

            // only from players
            // FIXME: need use SpellDamageBonus instead?

[VladimirMangos]

In [8986]. Thank you

[Revils]

I think resilience should affect only damage from player so why not put a check just like on the comment below?

@@ -6824,11 +6824,12 @@ void Aura::PeriodicTick()
            // send critical in hit info for threat calculation
            if (isCrit)
            {
                cleanDamage.hitOutCome = MELEE_HIT_CRIT;
                // Resilience - reduce crit damage
-                pdamage -= m_target->GetSpellCritDamageReduction(pdamage);
+                if (IS_PLAYER_GUID(m_caster_guid))
+                    pdamage -= m_target->GetSpellCritDamageReduction(pdamage);
            }

            // only from players
            // FIXME: need use SpellDamageBonus instead?
            if (IS_PLAYER_GUID(m_caster_guid))

or there's a check to prevent non player to crit at all?

also, on 3.2.2. patch notes:

"Resilience: No longer reduces the amount of damage done by damage-over-time spells, but instead reduces the amount of all damage done by players by the same proportion. In addition, the amount of resilience needed to reduce critical strike chance, critical strike damage and overall damage has been increased by 15%."

so, this patch is it really necessary?

[dogeht]

I was wondering the same thing

[darkstalker]

this is the crit damage reduction part only

[VladimirMangos]

1) crit damage reduced for any attacker types, in different from normal damage reduction

2) as i re-check we not reduce this for this type dot in other place.