[9162][patch 8967] Allow SPELL_AURA_PERIODIC_LEECH to crit if able to.

[qsa]

revision : 8967

Allow SPELL_AURA_PERIODIC_LEECH to crit if they should be able to.

For example: Devouring Plague.

http://github.com/gc/mangos/commit/be729576f7efc42605b7ba56b29357eea61afd98

[Lynx3d]

If i may slightly bump this topic, i just came across the same problem and came to the same conclusion, period leech also needs to check if the aura is able to crit.

However i wonder if these lines from SPELL_AURA_PERIODIC_DAMAGE case also need to be added to SPELL_AURA_PERIODIC_LEECH (the resilience part has been added shortly after this suggested patch though):

06637             // send critical in hit info for threat calculation
06638             if (isCrit)
06639             {
06640                 cleanDamage.hitOutCome = MELEE_HIT_CRIT;
06641                 // Resilience - reduce crit damage
06642                 pdamage -= m_target->GetSpellCritDamageReduction(pdamage);
06643             }

[VladimirMangos]

In [9162] with suggested addition. Thank you