[Fix][9075] SpellEffect PlayerPull

[Auntie Mangos]

and EffectMiscValue is already used there.

Ok, but IMO not correctly - according to videos on youtube and comments on wowhead, the angle (or vertical speed) should depend on distance and the speed (horizontal speed) varies depending on spell used (ie. on EffectMiscValue) and on Mangos it is done other way round :huh:

I've written it there already http://getmangos.eu/community/viewtopic.php?id=5935

[FunkyBit]

What bug does the patch fix?

SpellEffect 124 (PlayerPull) didn't pull players. It pushed them away like a knockback.

For example this spell: Spell: Attract Magic

For which repository revision was the patch created?

MaNGOS-0.12, but same problem exists in Master. Code change is the same for both.

Who has been writing this patch?

me

diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp
index 1e2272f..ebd10ba 100644
--- a/src/game/SpellEffects.cpp
+++ b/src/game/SpellEffects.cpp
@@ -5628,7 +5880,7 @@ void Spell::EffectPlayerPull(uint32 i)
    if(!unitTarget)
        return;

-    unitTarget->KnockBackFrom(m_caster,float(damage ? damage : unitTarget->GetDistance2d(m_caster)),float(m_spellInfo->EffectMiscValue[i])/10);
+    unitTarget->KnockBackFrom(m_caster,-float(damage ? damage : unitTarget->GetDistance2d(m_caster)),float(m_spellInfo->EffectMiscValue[i])/10);
}

void Spell::EffectDispelMechanic(uint32 i)

[VladimirMangos]

In [9075] and 0.12. Thank you

[FunkyBit]

Yiippeeee!! ^^

[Tassader2]

Well, it's incorrect anyway ...

I think that EffectMiscValue determines the horizontal speed and vertical speed (or angle?) should be calculated from distance and horizontal speed so target lands (+-) right in front of caster (damage can probably be used to override it)

For example http://www.wowhead.com/?spell=37370 (EffectMiscValue=300) should pull players very fast, with very low vertical speed ... and to the caster, not far behind him like on mangos

And http://www.wowhead.com/?spell=32265 (EffectMiscValue=125) pulls players at much smaller horizontal speed, but higher vertical. And comments says "If you are far away, you are also pulled significantly upwards" ...

[DasBlub]

it has been fixed in [9076].

and EffectMiscValue is already used there.

[SilverIce]

+ don't forget that vertical\\horizontal speeds might be depend from distance to caster(caster position or center where those speeds has max values)

[Wessly]

How to fix the core with any of these patches?