Remove crowd control when damage is absorbed.

[Auntie Mangos]

Wrong topic I'm sure I was replying to http://getmangos.eu/community/showthread.php?14110-patch-Small-aura-related-change.

[dardennf]

Mangos Version: 9000+

How it SHOULD work: When you cast spell on target which have an absorbing effect, (like Power Word: Shield ) most of crowd control, like sap or blind... should disappear.

How it DOES work: Sap or others CC doesn't disappear when you cast a spell on target which have an absorbing effet.

Exemples :

Take a rogue, sap a priest who have PWS, cheap shot him and sap isn't removed.

Take a rogue, blind a priest who have PWS, mana burn the priest and blind isn't removed.

Sorry for my english.

PS : we need more informations, like with polymorph, freezing trap, banish, hibernate, repentance etc...

[dardennf]

I bump this post because bug still exists .

And I think this is important.

[darkstalker]

ye, noticed that too, but there are other spells (like hex) that should absorb some damage after the spell gets removed.

int Unit::DealDamage

if(!damage)
   {
       // Rage from physical damage received .
       if(cleanDamage && cleanDamage->damage && (damageSchoolMask & SPELL_SCHOOL_MASK_NORMAL) && pVictim->GetTypeId() == TYPEID_PLAYER && (pVictim->getPowerType() == POWER_RAGE))
           ((Player*)pVictim)->RewardRage(cleanDamage->damage, 0, false);

       return 0;
   }
   if (!spellProto || !IsSpellHaveAura(spellProto,SPELL_AURA_MOD_FEAR))
       pVictim->RemoveSpellbyDamageTaken(SPELL_AURA_MOD_FEAR, damage);
   // root type spells do not dispel the root effect
   if (!spellProto || !(spellProto->Mechanic == MECHANIC_ROOT || IsSpellHaveAura(spellProto,SPELL_AURA_MOD_ROOT)))
       pVictim->RemoveSpellbyDamageTaken(SPELL_AURA_MOD_ROOT, damage);

proably that "return 0" should be moved

[dardennf]

Yeah I don't know how it works for others spells like hex.

Maybe it breaks the effect with the same amount of damage received (with or without shield).

Need info from retail ^^.

Anyway thank you darkstalker.

[blukkie]

Is there a fix for this problem yet? I can't figure it out at the moment.

[zergtmn]

wrong topic

[dardennf]

Why ?

"Spellsteal wont break any Crowd Control effect on target".

So it doesn't matter, does it ?

edit (@zergtmn) : Ok np ^^.