raid bug

[Auntie Mangos]

Same here!

P.S. Master loot bug references here

[blackbahamut]

mangos revision:9245 linux_x64

udb: 0.11.6(386) for mangos 8994 SD2 SQL rev 1516

Hi,

I want to tell about some bugs that i test in raid groups:

1. For example, if we are 20 person and I add someone to the raid, this player appears in Group 1, independently if this group is full.

2. Sometimes i see disconnected people who aren't.

3. Group teams are confused.. people in group one appears a group five and viceversa..

4. When i give help leader status to one player and he wants to use his habilities like invite another players, game said error mensaje like 'you are not the leader'

5. Trouble about Master Loot.(anywhere can loot,and leader cannot give the items).

[Nykothino]

I also have the same problem when mounting a raid, it is folly to treat people of organisms

p.s Sorry for my English

[nvbk]

1. For example, if we are 20 person and I add someone to the raid, this player appears in Group 1, independently if this group is full.

Still bug in rev9406

[jenjena]

confirmed.

[balacas]

confirmed.

[jenjena]

confirmed.

[yavi]

Also, i'm expiriencing combat log hangups (no combat log) during raids. Maybe related?

[ANTOMA]

any progress in this? maybe find some temp fix?

[piroy1337]

confirmed

[Krak]

Also, i'm expiriencing combat log hangups (no combat log) during raids. Maybe related?

I found that combat log bugs for everyone when there is "Unknown" pet nearby. Not only in raid. Unknown pet happens when a player with active pet logouts or ends game by Alt+F4 and then log again. Maybe another cases...

[Homenixx]

Confirmed

[eNeRGy]

I found that combat log bugs for everyone when there is "Unknown" pet nearby. Not only in raid. Unknown pet happens when a player with active pet logouts or ends game by Alt+F4 and then log again. Maybe another cases...

This also happens on retail servers, so maybe this is client bug.

[Shad00w]

Confirmed and I add if you wont download someone(using Meeting Stone) you can't sometimes download persons in party.

[ankso]

Confirmed, also if a member of a group disconnects, and you try to move the disconnected player to another group, you have a lot of problems

[darkstalker]

that disconnected member moving problem has been since forever

raid ui problem started since 3.3.0 , it should be client/server packet mismatch

[tehavatar]

confirmed.

[Revils]

Confirmed with 9839

I did some test on debug and I didn't find any problem on code so, like darkstalker wrote, I suspect that there's something wrong on SMSG_GROUP_LIST implementation in Group::SendUpdate().

I noticed that this part was commited by tomrus88 on 2009-11-18 01:50:19 while 33x was still in PTR, so maybe the message changed when this version went live?

[vipertv]

I made a patch for this problem:

diff --git a/src/game/Group.cpp b/src/game/Group.cpp
index b616658..4004d2b 100644
--- a/src/game/Group.cpp
+++ b/src/game/Group.cpp
@@ -973,9 +973,9 @@ void Group::SendUpdate()
                                                            // guess size
        WorldPacket data(SMSG_GROUP_LIST, (1+1+1+1+8+4+GetMembersCount()*20));
        data << uint8(m_groupType);                         // group type (flags in 3.3)
-        data << uint8(isBGGroup() ? 1 : 0);                 // 2.0.x, isBattleGroundGroup?
        data << uint8(citr->group);                         // groupid
        data << uint8(citr->assistant ? 0x01 : 0x00);       // 0x2 main assist, 0x4 main tank
+        data << uint8(isBGGroup() ? 1 : 0);                 // 2.0.x, isBattleGroundGroup?
        if(m_groupType & GROUPTYPE_LFD)
        {
            data << uint8(0);

Edit:

This patch allows you to fix problems with using the function "raid assistant" as well as the correct display of position players on subgroups in the raid.

[Toinan67]

I made a patch for this problem:

What problem this patch is supposed to fix? It would be nice to specify

Edit : Ok, thanks for the patch!

[Revils]

I made a patch for this problem:

Thank you very much, it works!

[KAPATEJIb]

I made a patch for this problem:

please use code=diff tag next time

diff --git a/src/game/Group.cpp b/src/game/Group.cpp
index 3af15a6..004d999 100644
--- a/src/game/Group.cpp
+++ b/src/game/Group.cpp
@@ -980,9 +980,9 @@ void Group::SendUpdate()
                                                            // guess size
        WorldPacket data(SMSG_GROUP_LIST, (1+1+1+1+8+4+GetMembersCount()*20));
        data << uint8(m_groupType);                         // group type (flags in 3.3)
-        data << uint8(isBGGroup() ? 1 : 0);                 // 2.0.x, isBattleGroundGroup?
        data << uint8(citr->group);                         // groupid
        data << uint8(citr->assistant ? 0x01 : 0x00);       // 0x2 main assist, 0x4 main tank
+        data << uint8(isBGGroup() ? 1 : 0);                 // 2.0.x, isBattleGroundGroup?
        if(m_groupType & GROUPTYPE_LFD)
        {
            data << uint8(0);

you also should post it to Under Review section, or I can do it for you...

[vipertv]

you also should post it to Under Review section, or I can do it for you...

If you do this, I'll be very grateful, because my English is not very good.

[Krak]

There is also bug that player not in raid can be invited after killing a boss and then ported by warlock into the instance and loot items from boss. Only players who was there before should be able to get loot.