[patch] Add Positive Spell Check Before Call Attackstart In Onspellhit()

[megamage]

Now when bosses cast channel spells on some invisible trigger creature, the trigger will start to attack boss. There should be a positive spell check. I think players sometimes may also need to cast non-negative spells on netrual creature (some quests)

Index: Spell.cpp
===================================================================
--- Spell.cpp        (revision 6354)
+++ Spell.cpp        (working copy)
@@ -947,10 +947,7 @@
        {
                if( !m_caster->IsFriendlyTo(unit) )
                {
-                        // exclude Arcane Missiles Dummy Aura aura for now (attack on hit)
-                        // TODO: find way to not need this?
-                        if(!(m_spellInfo->SpellFamilyName == SPELLFAMILY_MAGE &&
-                                m_spellInfo->SpellFamilyFlags & 0x800LL))
+                        if(!IsPositiveSpell(m_spellInfo->Id))
                        {
                                unit->RemoveSpellsCausingAura(SPELL_AURA_MOD_STEALTH);

[Edoz]

why did you remove those lines? they seem to have little/nothing to do with your fix

[megamage]

If we do positive check the Arcane Missiles check is no longer needed.

[stfx]

Was possibly fixed in [6622] or later. Thanks