[10327][BUG] Argent Crusade Commendation Badge, spell 61311

[Ice_rulez]

http://www.wowhead.com/?spell=61311

Should be: Increases your Argent Crusade reputation by 520.

It is: Increases your Argent Crusade reputation by 400.

UDB 387

MaNGOS 9397 CentOS 5.4 Linux_x64

SD2 1570

[Wowka321]

I thing it's bag in description. cuz effect has 400.

[Ceris]

this is maybe because in 3.3.0 patch notes is this

2

• 2
  

maybe this is done by some "worldwide constant", which is affecting every way reputation could be gained: commandation badges, daily quests, ... and the reputation is not changed on every single item/quest. Maybe adding something like ReputationMultiplier could help solve this issue. Use of some kind of this constant could explain, why description of effect and description on item is different.

[sinaka]

with this patch (maybe hack) it gets fixed i'll post it in patch-section

diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp
index 43c1ccd..86b6cf5 100644
--- a/src/game/SpellEffects.cpp
+++ b/src/game/SpellEffects.cpp
@@ -6704,6 +6704,16 @@ void Spell::EffectReputation(SpellEffectIndex eff_idx)
    int32  rep_change = m_currentBasePoints[eff_idx];

    uint32 faction_id = m_spellInfo->EffectMiscValue[eff_idx];
+    switch(m_spellInfo->Id)
+    {
+        case 69757:
+        case 61311:
+        case 61308:
+        case 61306: 
+        case 61312:
+            rep_change *= 1.3;
+            break;
+    }

    FactionEntry const* factionEntry = sFactionStore.LookupEntry(faction_id);

[raftom]

what about the 2nd effect of for example http://www.wowhead.com/spell=61311?

is it somehow connected to this 30% extra reputation?

[Lynx3d]

maybe this is done by some "worldwide constant", which is affecting every way reputation could be gained: commandation badges, daily quests, ... and the reputation is not changed on every single item/quest. Maybe adding something like ReputationMultiplier could help solve this issue. Use of some kind of this constant could explain, why description of effect and description on item is different.

We (well mostly NoFantary) pretty much came to the same conclusion and implemented it, finally

Apparently Bl... has some big tweaking know to scale reputation globally, now implemented in reputation_reward_rate table.

What the dummy effect does is unknown, but i doubt it has anything to do with global reputation rates, because Argent Dawn Valor Token does not have a dummy effect yet it gives double the rep. in its base points now, as does every kill and quest.

Rates for spells implemented in [10327].