[patch] combat log changes for healing spells

[faramir118]

3.2 added:

• * heal absorb effects
  * new field for combat log heal events to handle heal absorb
  

This patch implements both.

patch for rev. 9559:

http://pastebin.com/raw.php?i=xB17iiTf

Examples of spells this handles:

• * Incinerate Flesh
  * Necrotic Strike
  

Example of combat log with patch:

Testadin's Necrotic Strike hits Testadin for 3587 Physical.
Testadin's Flash of Light heals Testadin for 0.(1737 Absorbed)
Testadin's Flash of Light heals Testadin for 0.(1730 Absorbed)
Testadin's Flash of Light heals Testadin for 0.(1718 Absorbed)
Testadin's Flash of Light heals Testadin for 0.(1736 Absorbed)
Testadin's Flash of Light heals Testadin for 0.(1750 Absorbed)
Testadin gains 92 Mana from Testadin's Illumination.
Testadin's Flash of Light heals Testadin for 0.(2655 Absorbed) (Critical)
Testadin gains 92 Mana from Testadin's Illumination.
Testadin's Flash of Light heals Testadin for 0.(2644 Absorbed) (Critical)
Testadin gains 92 Mana from Testadin's Illumination.
Testadin's Necrotic Strike dissipates from Testadin.
Testadin's Flash of Light heals Testadin for 1523.(1030 Absorbed) (Critical)
Testadin's Flash of Light heals Testadin for 1736.
Testadin's Flash of Light heals Testadin for 134.(1683 Overhealed)

[TOM_RUS]

Why you removed uint8 at the end of packet?

[shauren]

absorb field does have use with auras from the first effect of http://www.wowhead.com/?spell=66237

[faramir118]

Why you removed uint8 at the end of packet?

Didn't seem to change behavior with or without it.

Also, http://www.wowwiki.com/API_COMBAT_LOG_EVENT indicates that only source, target, spell, amount, overheal, absorb, and critical are needed on the client.

If there's a reason it SHOULD be there, I can add it back in.

absorb field does have use with auras from the first effect of http://www.wowhead.com/?spell=66237

Thank you! I couldn't find a spell with the heal-absorb effect. I'll start working on implementing it.

[TOM_RUS]

Client expects additional byte at the end.

[faramir118]

Updated original post.

Client expects additional byte at the end.

Added it back in, BUT:

How do you know it wants the additional byte after actual data? Is that information correct for client 3.2 and later?

Anyway, until now we were sending 3 bytes fewer than the client needed to even display correct information, and it still worked. It's not a big deal, but I don't think sending that last byte matters.

[darkstalker]

tested it, works fine, but not for healing over time spells

edit: updated patch for 9619 and added the HoT absorb part

http://paste2.org/p/735414

[faramir118]

Updated for 9750: http://paste2.org/p/775871