[fix]roll pass/need displaying in chat

[Auntie Mangos]

older bug, for 3.2.2 I had to use:

-item-rolling-popup-option"]http://getmangos.eu/community/showthread.php?11149-[bug]-item-rolling-popup-option

I though with latest changes on master it was fixed but I didn't have chance to test it so it seems it's still bugged

[laise]

What bug does the patch fix? What features does the patch add?

fixes passed roll that was displaying as need roll and need roll that had wrong message on need select

For which repository revision was the patch created?

9613

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

https://mangos.lighthouseapp.com/projects/18208/tickets/416-pass-on-loot-roll-shows-wrong-log-entry

Who has been writing this patch? Please include either forum user names or email addresses.

me

diff --git a/src/game/Group.cpp b/src/game/Group.cpp
index 961b82a..8541b3d 100644
--- a/src/game/Group.cpp
+++ b/src/game/Group.cpp
@@ -721,14 +721,14 @@ bool Group::CountRollVote(ObjectGuid const& playerGUID, Rolls::iterator& rollI,
    {
        case ROLL_PASS:                                     // Player choose pass
        {
-            SendLootRoll(playerGUID, 0, ROLL_PASS, *roll);
+            SendLootRoll(playerGUID, 128, ROLL_PASS, *roll);
            ++roll->totalPass;
            itr->second = PASS;
        }
        break;
        case ROLL_NEED:                                     // player choose Need
        {
-            SendLootRoll(playerGUID, 0, ROLL_NEED, *roll);
+            SendLootRoll(playerGUID, 0, 0, *roll);
            ++roll->totalNeed;
            itr->second = NEED;
        }

[cyrex]

Thank the lord!

[darkstalker]

the values look strange, but works perfectly.

the packet structure isnt correctly interpreted here, maybe update the enum?

[laise]

enum is used for other stuff and there it works fine so only this 2 problem, actually inSendLootRoll there are comments on what should be sent

[laise]

no longer needed