[Dev] Multi threaded Acution House

[wow-masters]

I have recently coded a multi threaded auction house for Mangos.

Wat does this do?

It will improve your performance rating if there is a lot more auctions.

V1: http://pastebin.com/DgABpwU4

V2: http://pastebin.com/fS68MwgF Added Some More Mutex Locks // clean up

V3 http://pastebin.com/rpvuDDsZ Compile Fix // More Mutex Locks

To do!

Add mutex locks.

Please reply anything else that needs doing to this patch.

[xeross155]

I'll give it a go on my server, does it work with AHBot ?

[wow-masters]

Hello,

Yes it should work with the AHbot,

If compile does not work please post back here. or any errors you have got.

[KuraiNeko]

Error    1    error C2664: 'ACE_Based::Thread::Thread(ACE_Based::Runnable *)' : cannot convert parameter 1 from 'AuctionHouseMgr' to 'ACE_Based::Runnable *'    F:\\zero mmaps\\MaNGOSZero\\src\\game\\World.cpp    1146    1    game

- compilation without mutex.

With mutex more errors.

[lillecarl]

How much performance does auction house really take on the server? Also you should give some more information about how your threading model works etc....

- LilleCarl

[Patman128]

I'm sorry, but you really need to look up how threads and mutexes work before trying something like this.

You use the mutex lock and unlock 3 times, and one of them is in the definition of class, which makes absolutely no sense.

As well, there are other functions which modify the data in AuctionHouseMgr, none of which you bothered to use the mutex with. This is like having a house with a thousand doors, putting a lock on one of them, and expecting it to be safe.

[KuraiNeko]

O_o

on master compilation without errors???

I have on zero - one error without mutex

& more with.

O_o