[fixed][mangos-0.12][crash][map]

[Auntie Mangos]

I rollbacked 8eb70eff6e9727a404e095a9978add4fd09677fc and crash stoped .

Now i endeavor backporting related fix patch from master to last rev of mangos-0.12 .

not tested stability yet

[some-backporting-from-master]"]This Patch

[mns]

rev : 421b2459a5c62c032c2a61f22ff6c52030dc9038

over 30 crash in day

http://paste2.org/p/754343

[balrok]

hello, yesterday i found the commit which crashed it, but had no time for a report or even a fix:

i don't know exactly how to crash, but i guess it's crashing when you do alt+f4 in instances

the mangos-commit which introduced the crash is:

8eb70eff6e9727a404e095a9978add4fd09677fc

so reverting it will stop the crash

also it seems that backporting some other commits can fix that crash too:

http://pastebin.com/5Zkg5Z36

this backport consists of several other commits, i mostly diffed the Map.cpp and took the changes for that specific function

but had no bigger testruns yet..

[mns]

ok

I first rollback 8eb70eff6e9727a404e095a9978add4fd09677fc patch then if stop crashing use fix patch and test again

very thx for fast reply

[tehavatar]

Sounds like someone was lazy.

[balrok]

this bunch of patches will work: http://pastebin.com/razGA5EN

(my backport-patch, which i posted in the top of this thread just introduced other crashes )

and now the patch is also tested (i think server is running two days now..)

[mns]

thx balrok but why you not commited this too Mangos-0.12 ?

I endeavor use backporting because Vladimir alway endeavor for Increase compatibility mangos-0.12 to master

if we use not compatible patch for fixing then future backporting will be too hard .

[VladimirMangos]

Agree with last remark. Not see reason have different way code changes in branches for similar working code parts. Mns backport added to mangos 0.12. This must resolve problem.

Nice another result in simplify backporting other related changes.

In ideal state we must have branches different only in parts that work in different way in related client versions.