[10052][patch] Camera system

[Biali]

anyone? T_T

[alexluana]

will this patch ever get to under review... section?

Does it needs more testing and adjustments? Cause is darn wonderful to have it in a server!

With respect,

Axel

[Biali]

oh sorry! i was clicking on that first link! I didnt noticed the other one at the bottom!! ><

I'll try it again

thank u silverice!!!

[ilija]

What happens with memory / cpu usage with this patch?

[Patman128]

What happens with memory / cpu usage with this patch?

The point of this patch isn't to change memory/CPU usage but how the client interacts with the objects (players/creatures) on the server.

I would imagine it would be about the same, maybe a slight increase due to the overhead of the cameras.

[Biali]

@SilverIce I can see u r still updating ur branch but u r not releasing diffs anymore.

I am so noob in these git stuff but, well, I was trying to create the diff by my self using the steps gave in the vehicles topic and changing names to camera:

git clone git://github.com/mangos/mangos.git

cd mangos

git checkout -b camera

git pull http://github.com/SilverIce/mangos.git camera

git diff -p master camera > camera.patch

but it does not works...

when I try git pull http://github.com/SilverIce/mangos.git camera it says:

error: pick-rref: refs/heads/camera not found

No such ref refs/heads/camera at http://github.com/SilverIce/mangos.git

is there any other way to create a diff from SilverIce branch to main mangos branch??

thank you all in advance!

[Unkle Nuke]

It helps to actually read the names of the branches in SilverIce's Github repo. If you do not provide the proper branch name, your pull will fail.

For his cameras patch, the branches are named Cameras_clearly and cameras_changed.

[Novo]

EDIT:

after fixing OUR source, your patch works fine.

Thanks!

[SilverIce]

Have you tested it on clean sources?

currently tested by myself - no problems

not related to cameras. It could be a problem of all posses spells or problem of eye of acherus demo patch ( as i said - it's only a demo)

[vladex]

SilverIce , he is using another core , custom probably ,so it isn't fully compatible with mangos patches .

[Novo]

SilverIce , he is using another core , custom probably ,so it isn't fully compatible with mangos patches .

yep it was our fault. now it works.

Thanks!

[vladex]

silverice , may i request a repo update please ? im getting conflicts with mmaps and other addons

[HSC_Dev3]

silverice is there any way you can think of to merge this patch with the vehicles patch? they both use a part of player.cpp and player.h that I am not sure are compatible... been working on it for a few hrs now.. if this current build test doesnt work I am stumped though

[SilverIce]

silverice , may i request a repo update please ? im getting conflicts with mmaps and other addons

Sure. branch updated

There is one question to players on official servers:

Does your player became invisible for you(like other nearby objects), when eye of acherus or priest's Mind Vision spell target(or another viewpoint) placed too far from your player?

[vladex]

i got some errors on my core with mmaps addon vehicle ahbot and others. Here is a part of them:

http://paste2.org/p/872245

[HSC_Dev3]

i got some errors on my core with mmaps addon vehicle ahbot and others. Here is a part of them:

http://paste2.org/p/872245

you are not going to easily get vehicles to merge with cameras... the rest shouldnt produce any errors though vladex

[DaViper]

i got some errors on my core with mmaps addon vehicle ahbot and others. Here is a part of them:

http://paste2.org/p/872245

Hey that looks like my core....What are you doing trying to copy me?.....I do have a problem with trying to compile with pretty much the same configuation.

[vladex]

well i preety much opted for a 100 % everything functioning core .I have (mmaps+vmaps)_rewrite,vehicles,ahbot,playerbot,eye of acherus,some other spell fixes and thats about it. Didn't tryied to copy your core yet

[kaxias]

what is the difference of the camera system for vehiches patch?

[Unkle Nuke]

Welcome back, kaxias! I used to use nearly all of the branches in your repo for my patches, since you were very good about keeping them up to date with MaNGOS master. I hope you will do so again.

As to why there's a conflict between SilverIce's camera patch and Vehicles, I can only say most of that blame would be due to the fact that both projects are unrelated. Perhaps once one or the other makes it into the core, then there will be incentive to make compatible code. As it stands now, the Vehicle devs are more concerned with just getting vehicles working correctly. I can only assume then they will consider camera issues, once everything else is fixed.

[VladimirMangos]

In [10052]. Thank you

[Curious]

Thanks for time spend on this project

As for now which spell are affected ?

Eye of killrog

Eye of the beast

Priest and Shaman farsight

Engineering google

Eye of acherus quest

?

[Electros]

tryed with udb 391, mangos 10053 (no db changes and no custom patches), the eye of acherus not working, other not tested

[Mythli]

This is just a core modification, you have to apply his "eye of archerus" demo patch to get this quest working.

[kaxias]

Welcome back, kaxias! I used to use nearly all of the branches in your repo for my patches, since you were very good about keeping them up to date with MaNGOS master. I hope you will do so again.

Thank you for using my RIPO, and must have acid is useful to you!