Jump to content

[bug] Heart of the wild (druid feral talent)


Guest DJNefast

Recommended Posts

  • 2 weeks later...

Wowka321: To make it work fine:

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index d444dc9..cb4a35a 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -6198,8 +6198,8 @@ void Aura::HandleShapeshiftBoosts(bool apply)
                    if ((*i)->GetSpellProto()->SpellIconID == 240 && (*i)->GetModifier()->m_miscvalue == 3)
                    {
                        int32 HotWMod = (*i)->GetModifier()->m_amount;
-                        if(GetModifier()->m_miscvalue == FORM_CAT)
-                            HotWMod /= 2;
+//                        if(GetModifier()->m_miscvalue == FORM_CAT)
+//                            HotWMod /= 2;

                        m_target->CastCustomSpell(m_target, HotWSpellId, &HotWMod, NULL, NULL, true, NULL, this);
                        break;

Link to comment
Share on other sites

  • 3 weeks later...
its hacky, never will be accepted

a more correct way would be doing the effect in Player::UpdateAttackPowerAndDamage, since its only a dummy aura now.

Lol, and i don't post this under review topic.

If you ask blizz: give me full version DBC please!!! xD than no one hacks not needed in core.

BTW, what are you think about some spells like: 56815 (need Caster Aura State 56817), 48020 (need Caster Aura State 62388) and more-more with newest releases of client.

Or you think send fake packets to client better? o_O

And IMHO, hardcode bonuses more-more hackly in this case...

Just don't use this mega-hack for self.

Sorry about offtopic =\\

Link to comment
Share on other sites

i always tought that retail server has lots of hacks too, because "everything works" there doesn't mean the code is clean and perfect, we can't see that from an user point of view.

ontopic: just noticed that current implementation is wrong anyway, uses basepoints of effect0 (intellect buff) instead of effect1 (bear/cat buff)

Link to comment
Share on other sites

a simpler hack patch:

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index aebaf8a..d18b776 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -5930,7 +5930,7 @@ void Aura::HandleShapeshiftBoosts(bool apply)
    {
        case FORM_CAT:
            spellId1 = 3025;
-            HotWSpellId = 24900;
+            HotWSpellId = 30902;    // spell 24900 removed in 3.3.3
            MasterShaperSpellId = 48420;
            break;
        case FORM_TREE:
@@ -5947,13 +5947,13 @@ void Aura::HandleShapeshiftBoosts(bool apply)
        case FORM_BEAR:
            spellId1 = 1178;
            spellId2 = 21178;
-            HotWSpellId = 24899;
+            HotWSpellId = 19255;    // spell 24899 removed in 3.3.3
            MasterShaperSpellId = 48418;
            break;
        case FORM_DIREBEAR:
            spellId1 = 9635;
            spellId2 = 21178;
-            HotWSpellId = 24899;
+            HotWSpellId = 19255;    // spell 24899 removed in 3.3.3
            MasterShaperSpellId = 48418;
            break;
        case FORM_BATTLESTANCE:
@@ -6085,9 +6085,7 @@ void Aura::HandleShapeshiftBoosts(bool apply)
                {
                    if ((*i)->GetSpellProto()->SpellIconID == 240 && (*i)->GetModifier()->m_miscvalue == 3)
                    {
-                        int32 HotWMod = (*i)->GetModifier()->m_amount;
-                        if(GetModifier()->m_miscvalue == FORM_CAT)
-                            HotWMod /= 2;
+                        int32 HotWMod = (*i)->GetSpellProto()->CalculateSimpleValue(EFFECT_INDEX_1);

                        m_target->CastCustomSpell(m_target, HotWSpellId, &HotWMod, NULL, NULL, true, NULL, this);
                        break;
@@ -6102,6 +6100,8 @@ void Aura::HandleShapeshiftBoosts(bool apply)
            m_target->RemoveAurasDueToSpell(spellId1);
        if(spellId2)
            m_target->RemoveAurasDueToSpell(spellId2);
+        if(HotWSpellId)
+            m_target->RemoveAurasDueToSpell(HotWSpellId);
        if(MasterShaperSpellId)
            m_target->RemoveAurasDueToSpell(MasterShaperSpellId);

only problem is that hotw bonus doesn't get applied on login, don't know why

Link to comment
Share on other sites

Can someone tell me what I need exactly for fix this talent? (Which patch?, SQL part too?)

Thank´s.

all-in-one http://github.com/insider42/mangos/commit/486307e49154a88eafa334e50fa3526b77020366

then you can apply http://github.com/insider42/mangos/commit/ef5953f3f03c6359fb31c79a735328b14f638eac to fix Rune Strike for DK

and http://github.com/insider42/mangos/commit/4b3ceae3ffbdb1602e74980e2d6e81928ac3fcfe to fix Demonic Circle for Warlocks

Link to comment
Share on other sites

  • 1 month later...
×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use