[dev] Random Battleground

[DJNefast]

hi guys,

i work on 3.3.3 random battlegrounds, i give u step of my dev

Warning, my core is 9313 rev with many improvements of next revs but not all then it's not sure this is full compatible with daily cores

Rev 1 : You can join Queues

rev 2: generate the right map !

rev 3 : correct amount of honor gained by RBattleground in BuildBattleGroundListPacket function

rev 4 : you cannot join queue if : you are in queue for other bg, you want to go in queue but you are in queue for RBG

rev 5 : handle random bg differently

rev 6 : remove hacky fix on BattleGroundMgr.cpp, i'll take proper way this evening

rev 7 : generate random map (some problems in queue i think)

rev 8 : All works Enjoy

rev 9 : fix alone join bug (sorry, forget it in dev branch )

repo : http://github.com/nerzhul/MangosOpenDev/tree/RandomBG

Works succesfully. If you have any questions or issues write here

1 persistent bug for those bg (my queue for RB is 1 to 40 players :

proc bgs are only 1v1 players

You need to relog when you are teleported to can join another time a queue

[DJNefast]

added player Set and HasDone random BG function to main topic for full compatibility

[Unkle Nuke]

Could you please make your MangosFX repository public or at least create a public repository for your Random BG patch?

Thank you for offering us your work, bon homme.

[DJNefast]

as i say i have 9313 rev core, with many updates from myself and good repos (valhalla, insider and trinitycore (joke not this ))

then my core is very very outdated for you, it's why i take you hand patch weak to implement

MangosFX repo will be opensource when my server get 1000 players not before (6days uptime with 120 players , many improvements and CORBA project on mangos ) and also LibDevFS which is a great upgrade of ScriptDev2 with many improvements and fastly to code IA's

EDIT : revision 4 coming, queues are now properly handled

i'm creating mangos fork for u guy but support is done by forum and instant update are there, not on git next time i wish

http://github.com/nerzhul/MangosOpenDev/

it's on git

not all because mangos hasn't all my methods like reset BGDaily

[Patman128]

Could you please remove the link to your server from your sig?

[DJNefast]

it's not allowed ?

rev7 will create battleground i do many tests on my server next time

rev7 now template is used. We need more stuff in queues because it generate

BattlegroundHandler: itrplayerstatus not found.

error

i'll try to correct it later

[DJNefast]

rev 8 will coming soon.

Random BG are properly handled, at this time i search to resolve battleground status when you're in the bg

[DJNefast]

rev8

Random Battleground now works

i make it properly and i hope vladimir get it for mangos core no hacks therory

[Fyurie]

Very good, and fast () work. Hope to see more from you in the future mate.

[DJNefast]

true developped in 2hours total time (i am working on php XenServer monitoring and dev it at the same time )

[pred]

good thx

[ogda]

lol, Awesome work, a big thanks <3

[Patman128]

How about an actual patch file? I don't think vladimir is going to go through each file, find everything, and change it by hand.

[DJNefast]

later.

Actually there is a bug only 1c1 bgs i must search, this evening if i get time.

this is a little patch if someone want to create it go i haven't time to generate it now

[cristinel]

rev8

Random Battleground now works

i make it properly and i hope vladimir get it for mangos core no hacks therory

oh on your git repo you have only the rev 4

[DJNefast]

sorry i haven't get time to do this, tomorrow i think

[cristinel]

oh.... can you please update for me and for other people i will apreciate that

And nice work.

[DJNefast]

repo updated

if someone find how to drop 1v1 bug for those BGs, please tell me

[cristinel]

found a problem you cannot join random battleground with a single player only if you are in group and the leader press join as group...

[DJNefast]

urgl ? i don't have this bug i've found group bug me i can't join if i'm in a group, i must support it later

oh my god i forget to drop one thing in the repo patch

after that you can join alone

in battlegroundhandler.cpp

replace

if (!_player->HasFreeBattleGroundQueueId() || _player->HasFreeBattleGroundQueueId() && bgTypeId == BATTLEGROUND_RB)

by

if (!_player->HasFreeBattleGroundQueueId())

EDIT: repo updated

[Wowka321]

found a problem you cannot join random battleground with a single player only if you are in group and the leader press join as group...

From patch note

The Random Battleground option will only allow a group size of 5 players to queue together.

[DJNefast]

you can join alone wowka321, it's just a limit and missing revert part from me

[cristinel]

Thank You for the fast update i will test it

[DJNefast]

enjoy and give me report if you get bugs (if you dont have my reported bug please tell me )

[cristinel]

Now i found this one

When you press the button for queue and than you teleport in other place with a teleporter you are out of queue and you need to relog to join again.