[9991-9992][patch] Raid bugs fix

[Auntie Mangos]

What bug does the patch fix? What features does the patch add?

1) fixed work of raid assistant

2) fixed problem when sometimes players see other of raid members as "logged off" but these players is in game

3) fixed problem when sometimes players wrongly shown as member of other group in raid but it's really in your group

4) maybe something else...

For which repository revision was the patch created?

9867

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

http://getmangos.eu/community/showthread.php?12358

Who has been writing this patch? Please include either forum user names or email addresses.

vipertv

diff --git a/src/game/Group.cpp b/src/game/Group.cpp
index 3af15a6..004d999 100644
--- a/src/game/Group.cpp
+++ b/src/game/Group.cpp
@@ -980,9 +980,9 @@ void Group::SendUpdate()
                                                            // guess size
        WorldPacket data(SMSG_GROUP_LIST, (1+1+1+1+8+4+GetMembersCount()*20));
        data << uint8(m_groupType);                         // group type (flags in 3.3)
-        data << uint8(isBGGroup() ? 1 : 0);                 // 2.0.x, isBattleGroundGroup?
        data << uint8(citr->group);                         // groupid
        data << uint8(citr->assistant ? 0x01 : 0x00);       // 0x2 main assist, 0x4 main tank
+        data << uint8(isBGGroup() ? 1 : 0);                 // 2.0.x, isBattleGroundGroup?
        if(m_groupType & GROUPTYPE_LFD)
        {
            data << uint8(0);

or http://paste2.org/p/822940

[Forusim]

Is the solution really that simple?

[silvermcd]

also if a player dies he can release and reenter the battle, that's a little abused, loots from gameobjects are "free-for-all" (anyone can ninja) and master loot and character animations (they bug like a char is stopped but it's always running in my game) are also working bad in some dungeons like trial of crusader and trial of the champion

[ankso]

character animations (they bug like a char is stopped but it's always running in my game)

This only happens when you enter into a instance mounted I think

[darkstalker]

This only happens when you enter into a instance mounted I think

happens everytime you change map while in flying mount, but not related to this.

about raids, even with this patch you still see other raid members offline when not in same map

[KAPATEJIb]

about raids, even with this patch you still see other raid members offline when not in same map

i think this appears after last Ambal's map patch, so not related to this fix. Fix need to send correct packet structure for client

[Revils]

This will also fix main tank and main assistant flags: http://paste2.org/p/832080

I know it's a really ugly patch, it was just for testing the opcodes and see what's wrong in the code.

IMHO assistant,main assistant and main tank should be handle as a generic member flag rather than keeping separated and stored differently on DB so I think this part of the code about raid group need more work

[VladimirMangos]

This will also fix main tank and main assistant flags: http://paste2.org/p/832080

I know it's a really ugly patch, it was just for testing the opcodes and see what's wrong in the code.

IMHO assistant,main assistant and main tank should be handle as a generic member flag rather than keeping separated and stored differently on DB so I think this part of the code about raid group need more work

Patch mostly work, but need check guid before call set functions for remove setting also, because cleitn can send wrong pairs (for example, send remove main tank for guid not set as main tank currently.

In [9991-9992] added 2 patches from this thread with changes. Thank you to authors