[patch] Add loot-rules for chests

[Guest]

What bug does the patch fix? What features does the patch add?

Add possibility to use loot-rules for any lootable object in world. In this case for chests with right data in DB.

For which repository revision was the patch created?

9933

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

http://getmangos.eu/community/showthread.php?13160-BUG-Loot-chests&highlight=master+loot

Who has been writing this patch? Please include either forum user names or email addresses.

me

patch

Maybe need some corrections, cuz was written by fast-hands

[ankso]

Tested and works good - thanks!

[DasBlub]

this patch looks a bit hacky:

+                    if(Group* group = GetGroup())
+                    {
+                        if (group == this->GetGroup())

why do you check again if it's that value which you have just set? GetGroup() is the same as this->GetGroup()

also, those if's are strange, instead of something like

if(a) {
 if(b) {
   ...
     if(z) { ...}
 }
}

you can just do

if(a && b ... && z) { ... }

-- DasBlub

[Patman128]

I do not believe you can combine if(Group* group = GetGroup()) and if (group == this->GetGroup())

If you use "if((Group * group = GetGroup()) && group == this->GetGroup())" you will most likely get an error about group not existing.

[DasBlub]

that's not what i said.

i said it's useless to check again if group is, what you just set.

it's the same if i'd do this:

if(int x = 42) {
 if(x == 42) {
   ...
 }
}

[Wowka321]

It just copy-paste from existing code

First we check for group existing, second, that this looter in same group ( i hope ).

[Schmoozerd]

Move this thread to rejected, because alternate (though based on this) version added.

Thank you