[fix] Spell Reflection

[Auntie Mangos]

* What bug does the patch fix? What features does the patch add?

Spell Reflection should not work with AoE spells

* For which repository revision was the patch created?

8569 0.12

* Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

http://getmangos.eu/community/showthread.php?13869-Spell-Reflection

* Who has been writing this patch? Please include either forum user names or email addresses.

me

http://paste2.org/p/841157

diff --git a/src/game/Spell.cpp b/src/game/Spell.cpp
index 64bd0f8..39be2d9 100644
--- a/src/game/Spell.cpp
+++ b/src/game/Spell.cpp
@@ -344,9 +344,9 @@ Spell::Spell( Unit* Caster, SpellEntry const *info, bool triggered, ObjectGuid o
            if (m_spellInfo->Effect[j] == 0)
                continue;

-            if(!IsPositiveTarget(m_spellInfo->EffectImplicitTargetA[j], m_spellInfo->EffectImplicitTargetB[j]))
+            if(!IsPositiveTarget(m_spellInfo->EffectImplicitTargetA[j], m_spellInfo->EffectImplicitTargetB[j]) && !IsAreaOfEffectSpell(m_spellInfo))
                m_canReflect = true;
-            else
+            else if (!IsAreaOfEffectSpell(m_spellInfo))
                m_canReflect = (m_spellInfo->AttributesEx & (1<<7)) ? true : false;

            if(m_canReflect)

[reeshack]

An advice:

1) There is a function "IsAreaOfEffectSpell()"

2) Spell reflection is determined in "Spell::Spell()" in my opinion it is much better to do it there

[BugFix]

thanks for advice. updated first post

[Hundekuchen]

nice work, now i can delete my warrior :-P

[The_Game_Master]

Cool, should work for current branch as well. With small changes.

[Emme]

I found out that the flag currently used to determine can or not reflect is wrong

I tried out another flag that seemed fitting about one month ago and by now on a server with ~700 ppl online it seems to be the correct one.

It covers AoE Spells as well as most Boss Spells and some very weak Spells (mage armor for example).

This Patch also makes Magnet Auras not redirect those Spells.

Written for: 2a985c6bf0e58ac430a4e28c1ea418d7b29fe69c (mangos-0.12 Branch)

http://paste2.org/p/845075