[Fix] Warbringer - Warrior's Talent

[michalpolko]

MaNGOS Revision: 10459

What does it fix: with Warbringer talent Intervene ability should remove movement impairing effects.

Up till now it has been written in Unit::HandleOverrideClassScriptAuraProc():

case 6953:                                          // Warbringer
           RemoveAurasAtMechanicImmunity(IMMUNE_TO_ROOT_AND_SNARE_MASK,0,true);
           break;

but the problem was, that this part of code could work only when Intervene was cast. if warrior was held by roots, then Intervene couldnt be cast so HandleOverrideClassScriptAuraProc wasnt even executed.

from wowhead comments:

- Can be used to remove movement impairing effects:

- Crippling poison

- Hamstring

- Chains of Ice

- Slow

- Mind Flay (unconfirmed)

- Frost Nova

- Wingclip

- Earthbind

- Root

- and potentially all dazing effects.

-Click same ability twice and it will remove the impairing effect then charge, intercept, or intervene.

-Can be used in any stance

the most important part is: "-Click same ability twice and it will remove the impairing effect then charge, intercept, or intervene." this is about the old version of talent (before blizz nerfed it) but the part about double using the skill is still valid.

I wrote the patch for removing roots by intervene if warrior has the Warbringer talent with the first click (as written above) and then the second click would cast the Intervene spell.

Patch: http://pastebin.com/Crr8H6pg

here is a video from tests:

it was also tested with mage's frost nova.

pls test, comment, accept

EDIT: still browsing youtube and wow sites for more info about this roots breaking. with this we could spam intervene without losing rage or getting CD on it, it just requires the target in range. Im gonna need info directly from some wow player.

EDIT2: ok I think it can be confirmed by this video:

at 4:30 the warrior says that he uses Charge (it was before nerf) to break the frost nova, then he uses charge to get to the mage, a few seconds later he uses intercept, so there is no way that after breaking the frost nova he used intercept.

[Mylifesuxito]

i see the code and added manually to the spell.cpp compile it but doesnt work o.0 maybe i did it bad dont know

[michalpolko]

what is your rev of mangos?

[Mylifesuxito]

core: 10023

it seems to have some differents with the patch but i added manually and didnt work it compile fine but still broken

[michalpolko]

I have just tested it on 10020 and works fine. can anyone with rev10023 test it? I dont feel like updating my mangos now ;p

[michalpolko]

updated first post, patch for rev. 10051 provided, works fine for me. pls test and comment:]

[michalpolko]

updated for rev. 10459

[VladimirMangos]

hard review this part functionality before main part of spell functionlity...