[fix]SPELL_AURA_MOD_HEALING_DONE

[virusav]

There are spells that have the effect of the aura 135 (SPELL_AURA_MOD_HEALING_DONE), but additional treatment is not observed visually in becoming a player.

When casting a spell on the treatment of bonus is also not visible.

I looked through all spells with an aura of 135, who should be such a situation (for example, sorting 67684):

26276
37436
55637
60565
60566
60567
60568
60569
60570
63283
67684
70244 

In Unit.cpp in int32 Unit:: SpellBaseHealingBonusDone (SpellSchoolMask schoolMask) is a condition:

 if (((* i) -> GetModifier () -> m_miscvalue & schoolMask)! = 0) 

but for these spells:

(* I) -> GetModifier () -> m_miscvalue = 0

schoolMask = SPELL_SCHOOL_MASK_ALL / / 127

As a result, 0 & 127 = 0, so by the condition of the bonus is not calculated.

It seems to me, it is necessary to change the condition that such bonuses spells practiced.

Options:

 if (((* i) -> GetModifier () -> m_miscvalue & schoolMask)! = 0 | | (* i) -> GetModifier () -> m_miscvalue == 0)

 if (((* i) -> GetModifier () -> m_miscvalue & schoolMask)! = 0 | | schoolMask == SPELL_SCHOOL_MASK_ALL) 

Do yourself for the test set

 if (((* i) -> GetModifier () -> m_miscvalue & schoolMask)! = 0 | | ((* i) -> GetModifier () -> m_miscvalue == 0 & & schoolMask == SPELL_SCHOOL_MASK_ALL)) 

With such a condition all of the above spells visually give a bonus to treatment to become a player when casting spells + for treatment noticeable bonus.

Checked some spells to choose from with an aura of 135 not out of the list - bonuses are not changed.

I looked through all the places whence comes from entering SpellBaseHealingBonusDone, but found no call in a block with a condition that changes, ie altered condition does not violate the work of other spells.

In addition, before the loop is

 AuraList const & mHealingDone = GetAurasByType (SPELL_AURA_MOD_HEALING_DONE); 

Ie select all with this type of auras, ie others here, even can not penetrate.

What anyone thought about this, can one edit the data in such a way spells?

[laise]

in [10049]. Thanks =)

[pharaoh_bsb]

I seriously suspect this patch has nerfed Holy Priests a lot.

Snifff : )