[fixed] Overkill does not disappear after 20 seconds

[Auntie Mangos]

Mangos Version: 10018

Custom Patches: Broadcaster

SD2 Version: 1706

Database Name and Version : UDB 391

How it SHOULD work: Entering stealh(also with vanish) should give you http://www.wowhead.com/spell=58427, which should last 20 seconds after leaving stealth.

How it DOES work: It lasts forever or till you change map.

The bug came with switch to 3.3.3 because blizz have removed the triggeringspell 58428 and made 58427 persistent.

Here the link to closed accepted thread: http://getmangos.eu/community/showthread.php?6124-FIX-PATCH-7664-Overkill/page2&highlight=overkill

I think we need a remove after 20 seconds function somewhere...

[codhringer]

It works well for me.

[Forusim]

It works well for me.

Which Mangosrev do you have? Any patches?

[VladimirMangos]

Must be fixed in [10051]

[The_Game_Master]

Bump! Still not working in 10252.

[fdb_]

Tested on [10392] and does not disappear.

[Wowka321]

Fix:

http://github.com/Wowka321/mangos/commit/45c5757c160faab23d55cfc833cfc38c69666bac

[VladimirMangos]

Fix applied to [10405]. Thank you

[VladimirMangos]

Bump! Still not working in 10252.

It not "still not worked" but "has been broken one more time after"

[KarnRS]

Question: in 10405, procs with Vanish (26889) too? Maybe we're not in the right rev but the Overkill spell works fine with Stealth but not with Vanish.

Anyway thanks.

[Forusim]

I not sure why, but Vanish is filtered out.

I just commended this part out.

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index a6dceb9..0c6c885 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -3854,7 +3881,7 @@ void Aura::HandleModStealth(bool apply, bool Real)
                        target->CastCustomSpell(target,31665,&bp,NULL,NULL,true);
                    }
                    // Overkill
-                    else if ((*i)->GetId() == 58426 && GetSpellProto()->SpellFamilyFlags & UI64LIT(0x0000000000400000))
+                    else if ((*i)->GetId() == 58426/* && GetSpellProto()->SpellFamilyFlags & UI64LIT(0x0000000000400000)*/)
                    {
                        target->CastSpell(target, 58427, true);
                    }
@@ -3893,7 +3920,7 @@ void Aura::HandleModStealth(bool apply, bool Real)
                if ((*i)->GetSpellProto()->SpellIconID == 2114)
                    target->CastSpell(target, 31666, true);
                // Overkill
-                else if ((*i)->GetId() == 58426 && GetSpellProto()->SpellFamilyFlags & UI64LIT(0x0000000000400000))
+                else if ((*i)->GetId() == 58426/* && GetSpellProto()->SpellFamilyFlags & UI64LIT(0x0000000000400000)*/)
                {
                    if (Aura* aura = target->GetAura(58427, EFFECT_INDEX_0))
                    {

[Wowka321]

I did't deep research of this issue, but i solve it by

http://github.com/Wowka321/mangos/commit/d8265a4fa71e260d18b1380713202017303bde27

both auras is HandleModStealth, so we apply overkill on second (in this case is 1784)... but many solutions is possible. E.g. HandleSpellSpecificBoosts ))