[patch]Mainstreaming gender goals SCRIPT_COMMAND_CAST_SPELL

[Auntie Mangos]

Vladimir said that we must change effects in the core.

Result: http://getmangos.eu/community/viewtopic.php?id=14588

[virusav]

There are spells with the effect SPELL_EFFECT_SCRIPT_EFFECT, which must be cast spell, but with the goal of sex.

Example:

http://www.wowhead.com/spell=48762 - the main spell

http://www.wowhead.com/spell=48763 - for male

http://www.wowhead.com/spell=48761 - for women

For the team has engaged SCRIPT_COMMAND_CAST_SPELL datalong3.

The patch: http://paste2.org/p/913707.

At the base:

UPDATE `creature_movement_scripts` SET `datalong3` = 3 WHERE `command` = 15 AND `datalong3` = 0;
UPDATE `event_scripts` SET `datalong3` = 3 WHERE `command` = 15 AND `datalong3` = 0;
UPDATE `gameobject_scripts` SET `datalong3` = 3 WHERE `command` = 15 AND `datalong3` = 0;
UPDATE `gossip_scripts` SET `datalong3` = 3 WHERE `command` = 15 AND `datalong3` = 0;
UPDATE `quest_end_scripts` SET `datalong3` = 3 WHERE `command` = 15 AND `datalong3` = 0;
UPDATE `quest_start_scripts` SET `datalong3` = 3 WHERE `command` = 15 AND `datalong3` = 0;
UPDATE `spell_scripts` SET `datalong3` = 3 WHERE `command` = 15 AND `datalong3` = 0; 

For these spells:

DELETE FROM `spell_scripts` WHERE `id` = 48762;
INSERT INTO `spell_scripts` (`id`, `delay`, `command`, `datalong`, `datalong2`, `datalong3`) VALUES
(48762, 1, 15, 48763, 0, 1),
(48762, 1, 15, 48761, 0, 2);

[Schmoozerd]

sounds reasonable, but perhaps you should think about directly providing support for conditions, and not only m/f

There are enough free fields, but perhaps it would be more convenient to move momentarily datalong2 (src-target flag) to dataflags and use datalong2, 3 and 4 for condition entries -

taken from source/target depending on flags, or with hardcoded: try target before source or similar

[VladimirMangos]

So moving this version as outdated from under review..