[patch] Fix crash when attemping to access deleted aura holder

[zergtmn]

For 10227: http://paste2.org/p/920995

[laise]

alternative fix in [10255]. Can't check only last aura since aura remove can trigger different holder remove..

[zergtmn]

alternative fix in [10255]. Can't check only last aura since aura remove can trigger different holder remove..

And how it's related to this crash?

Crash happens on line:

if (Aura *aura = holder->GetAuraByEffectIndex(SpellEffectIndex(i)))

"holder" can be deleted in previous iteration but then accessed again.

Auras from same holder expire at the same time in most cases. But you force to start search from beginning every aura remove... Your solution is slower than mine.

Search will already start from beginning if at least one aura gets removed because of line:

removedAura = true;

[VladimirMangos]

nd how it's related to this crash?

Because holder can be deleted in chain event

holder H effect 0 remove -> some spell self damage cast -> target die -> auras remove -> holder H remove -> .... return back from calls

Your solution is slower than mine.

But your not work in general case..