Stealth disabled with hots

[maly32167]

This is what I wrote for this annoying bug, hacky but I couldnt find real source of it too, stealth has procflag & PROC_FLAG_ON_TAKE_PERIODIC but problem is with

- Taken spell periodic (damage / healing, determined from 14-17 flags) mangos doesnt determine whether its damage or healing (and I dont know wtf these 14-17 flags are..)

this code doesnt break anything but it doesnt change that its hacky and damage mismatch for proc may be bugging not only stealth...

diff --git a/src/game/UnitAuraProcHandler.cpp b/src/game/UnitAuraProcHandler.cpp
index 95bab48..838b6d7 100644
--- a/src/game/UnitAuraProcHandler.cpp
+++ b/src/game/UnitAuraProcHandler.cpp
@@ -383,6 +383,19 @@ bool Unit::IsTriggeredAtSpellProcEvent(Unit *pVictim, SpellAuraHolder* holder, S
        if (!allow)
            return false;
    }
+
+    if (EventProcFlag & PROC_FLAG_ON_TAKE_PERIODIC && GetTypeId() == TYPEID_PLAYER && procSpell && IsPositiveSpell(procSpell->Id))
+    {
+        bool allow = true;
+        for(int i = 0; i < 3; ++i)
+            if(Aura * pAur = holder->GetAuraByEffectIndex(SpellEffectIndex(i)))
+                if(pAur->GetModifier()->m_auraname == SPELL_AURA_MOD_STEALTH)
+                    allow = false;
+
+        if (!allow)
+            return false;
+    }
+
    // Aura added by spell can`t trogger from self (prevent drop charges/do triggers)
    // But except periodic triggers (can triggered from self)
    if(procSpell && procSpell->Id == spellProto->Id && !(spellProto->procFlags & PROC_FLAG_ON_TAKE_PERIODIC))

[tester20]

so what about http://www.wowhead.com/?spell=600 ??

it remove stealth too

[ankso]

maly32167, your code crashes my server a lot

[maly32167]

Ah, sorry Ankso - I forgot to check if procSpell exists at all, got this crash later too (didnt when I checked random hot)

[KAPATEJIb]

as i see this is fixed in [10522]

[Toinan67]

I'm not sure, but perhaps it is

[tester20]

as i see this is fixed in [10522]

no, it isnt

Anyone has tested this? it's secure?

no , it s break some healing procs(beacon of light for example)

we need something like

 
for (int32 i = 0; i < MAX_EFFECT_INDEX; ++i)
{
bool positive = (!triggered_spell_id && IsPositiveSpell(aurEff->GetId()) && aurEff->GetBase()->GetCharges()) ||
                               // check for positive auras that triggers unknown spells (Blessing Recovery, etc...)
                               (!sSpellStore.LookupEntry(triggered_spell_id) && IsPositiveSpell(aurEff->GetId())) ||
                               // final check for positive triggered spell
                               IsPositiveSpell(triggered_spell_id);
               if (!damage && (procExtra & PROC_EX_ABSORB) && isVictim && positive)
                   continue;

in Unit:: ProcDamageAndSpellFor

[laise]

aurEff->GetBase()

wth?

Can you please submit a patch in a diff format? and how positive checks related to periodic spells?

also what spells (ids) remove stealth, i tested with lifebloom and druid's prowl and it worked..

[tester20]

confirm hot heal dsnt breaking stealth

but much more stealth breaking spells left:

- http://www.wowhead.com/spell=6788 part of http://www.wowhead.com/spell=10901

- http://www.wowhead.com/spell=57723part of http://www.wowhead.com/spell=32182

and few other

[laise]

can you try after [10554]

[okjack]

hots don't break stealth anymore now. Thanks a lot. Everything is working fine