[patch]Balance Druid T10 2P Set Bonus Proc

[Auntie Mangos]

http://getmangos.eu/community/viewtopic.php?id=12757

[dpedroia15]

What bug does the patch fix? What features does the patch add?

The patch adds the dummy effects for the proc from the Balance Druid T10 2P Set Bonus.

For which repository revision was the patch created?

10330

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

No

Who has been writing this patch? Please include either forum user names or email addresses.

Me, dpedroia15

diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp
diff --git a/src/game/UnitAuraProcHandler.cpp b/src/game/UnitAuraProcHandler.cpp
index 8efae7c..98c8c13 100644
--- a/src/game/UnitAuraProcHandler.cpp
+++ b/src/game/UnitAuraProcHandler.cpp
@@ -1569,6 +1569,15 @@ SpellAuraProcResult Unit::HandleDummyAuraProc(Unit *pVictim, uint32 damage, Aura
                    pVictim->CastSpell(second, procSpell, true, NULL, triggeredByAura, GetGUID());
                    return SPELL_AURA_PROC_OK;
                }
+                //Item - Druid T10 Balance 2P Bonus
+                case 70718:
+                {
+                    if (!procSpell)
+                        return SPELL_AURA_PROC_FAILED;
+                    triggered_spell_id = 70721;
+                    target = this;
+                    break;
+                }
            }
            // Eclipse
            if (dummySpell->SpellIconID == 2856)

[dpedroia15]

I actually didn't see that thread. I think my handling of the 2P Bonus is the best way to do it, as it IS causing a dummy aura.

[kisslota]

https://github.com/mangos/mangos/commit/ac40c7e62c4550998bea58460ea58852cd84f8e0

Можно Удалять-Переносить тему

[VladimirMangos]

dpedroia15, your way also possible. But i seelect alt. way (in fact, sorry, i not see your patch version in commit time).

I select alt. way because 70718 not have procFlags. So in addition will need add spell_proc table record with manual set its.

So i think add it to spell cast code as triggered/precast will more clean.

In any cases thank you for patch