[unconfirmed] Infinite loop in TaxiHandler.cpp

[ankso]

MaNGOS: 10337

DB: YTDB 559

Well, I think I have found an infinite loop here:

void WorldSession::SendDoFlight( uint32 mountDisplayId, uint32 path, uint32 pathNode )
{
   // remove fake death
   if (GetPlayer()->hasUnitState(UNIT_STAT_DIED))
       GetPlayer()->RemoveSpellsCausingAura(SPELL_AURA_FEIGN_DEATH);

   while(GetPlayer()->GetMotionMaster()->GetCurrentMovementGeneratorType()==FLIGHT_MOTION_TYPE) // --> Here is the problem
   {
       // DEBUG_LOG("I'M NOW IN THE WHILE, IS IT INFINITE??");
       GetPlayer()->GetMotionMaster()->MovementExpired(false);
   }

   if (mountDisplayId)
       GetPlayer()->Mount( mountDisplayId );

   GetPlayer()->GetMotionMaster()->MoveTaxiFlight(path,pathNode);
}

I have some custom patches but nothing related to taxi paths, my server gets freezed sometimes and with that DEBUG_LOG I have found the loop where it fails. How to reproduce? Don't know, may be take flight paths until it gets stucked

If you have a freeze and the last output is: "WORLD: Taxi has to go from X to X" then this is your problem.

Any ideas or anyone has the same bug?

[VladimirMangos]

while(GetPlayer()->GetMotionMaster()->GetCurrentMovementGeneratorType()==FLIGHT_MOTION_TYPE) check top movement generator.

GetPlayer()->GetMotionMaster()->MovementExpired(false); remove top movegen unconditionaly

except single case: if (empty() || size() == 1)

when it single existed movegen. This is impossible in normal way becase player always has idle movgen as most deep.

ofc, if as you say, "custom patches" modify something in movegens in wrong way it can be sources of problem.

[DrKLO]

i think it's related to http://github.com/rsa/mangos/commit/b6d31044b7ea17630cab6f9001a31bcf0b67a536 patch

[VladimirMangos]

Then not mangos team problem. We can't prevent used function in wrong way in custom patches. And any results of like use not our problem

[Wojta]

i think it's related to http://github.com/rsa/mangos/commit/b6d31044b7ea17630cab6f9001a31bcf0b67a536 patch

Sorry but...why do you think so?

EDIT: yeah.. i see it now...thanks, I really should learn something about movement generators...