[IsHostileTo / IsFriendlyTo] Do they really need specific code?

[Toinan67]

Hi,

From what I've seen in Unit.cpp, IsHostileTo and IsFriendlyTo have exactly the same code, except for returns (which is quite normal).

I've spent 10 min trying to understand why, maybe something more in one function, but nothing, exactly the same.

So my question is : is there any reason for writing 2 times the same "algorithm" ?

I suggest a very simple modification :

bool Unit::IsFriendlyTo(Unit const* unit) const
{
   return !IsHostileTo(unit);
}

Tell me if I missed something.

[FeRkEl]

don't know but think isneutral?

the state isn't like a bool friend or enemy, i think

[Toinan67]

Yes I know, but in that case we have functions that return a bool, having (if I'm not wrong) exactly the same body.

I don't know how the "neutral" state is considered, I'd say neutral is more or less friendly.

[FeRkEl]

more or less friendly.. you can attack neutral if i'm right. and you can't attack friendly ones...

[faramir118]

Think of any faction, like Bloodsail Buccaneers:

If you are neutral with them (and haven't checked the 'at war' checkbox), both functions will return false.

I think IsFriendlyTo is supposed to determine if you are allowed to heal/buff a target. The client has its own checks for this, so you won't see perfect behavior (such as when you turn on cross-faction grouping, but can't heal each other).

[Toinan67]

Ok, the key thing is :

If you are neutral with them (and haven't checked the 'at war' checkbox), both functions will return false.

I actually didn't think about that. In my mind the 2 functions were "complementary", like "if you're not hostile you're friendly", if one returns true the other returns false.

Thanks