Jump to content

[fix] Use DEBUG_LOG for unexpected and wrong-status-req


Guest freghar

Recommended Posts

* What bug does the patch fix? What features does the patch add?

It moves 'received not allowed opcode' and 'received wrong-status-req opcode' to DEBUG_LOG, where "unhandled opcode" already is.

* For which repository revision was the patch created?

10523 (5c04687d47)

* Who has been writing this patch? Please include either forum user names or email addresses.

freghar

As said in the header, it makes more sense to move those two to debug log level, since they aren't really errors. If I remember correctly, "not allowed opcode" means the client sent a packet that is recognized by the server, but it's

  • * not implemented (but it has an opcode entry in some struct, so it's not "unhandled")
    * not correctly implemented (the client sends this opcode more often than server would expect / on special situations)
    * client bug / spoof attack / cheat attempt / ...

Which makes it not really more "critical" than unhandled opcodes.

I've never seen 'wrong-status-req' message, but since those other two should be in DEBUG log level and since this error message is most likely not user-correctable, I'd put it into debug as well.

http://paste2.org/p/1000242

Link to comment
Share on other sites

Agree with Spp_

if packet not allowed by set this is good report error. This let for devs know new packet cases handeled not propertly

Maybe with more info for cheating cases. We can't sort new unexpected in time packets cases or cheating. As always for like cases in fact.

But i agrre that hadnler Handle_NULL don't must output error (but debug instead) because if it called then packet allowed but not implemented

In [10544] implemented this way and 2 packets status updated.

Link to comment
Share on other sites

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use